Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArPow Tarball] Tier 4 - Add aspnetcore repo to arpow tarball #11113

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[ArPow Tarball] Tier 4 - Add aspnetcore repo to arpow tarball #11113

merged 1 commit into from
Aug 4, 2021

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Jul 13, 2021 •
edited
Loading

Fixes dotnet/source-build#2280

Once merged, I will port the first 2 patches back into the aspnetcore repo. I don't believe the third will be needed once the tarball is complete.

@MichaelSimons MichaelSimons changed the title [ArPow Tarball] Tier 3 - Add aspnetcore repo to arpow tarball [ArPow Tarball] Tier 4 - Add aspnetcore repo to arpow tarball Jul 13, 2021
@MichaelSimons
Copy link
Member Author

MichaelSimons commented Jul 13, 2021 •
edited
Loading

Summary of current status:

There are two issues called out here. If you workaround these within the tarball you will encounter the following build error:

/repos/installer/artifacts/tarball/src/aspnetcore.885cbe3ff7c844407404cf4e017275bcb59006df/artifacts/source-build/self/src/Directory.Build.props(229,3): error MSB4019: The imported project "/repos/installer/artifacts/tarball/src/aspnetcore.885cbe3ff7c844407404cf4e017275bcb59006df/artifacts/source-build/self/src/artifacts/bin/GenerateFiles/Directory.Build.props" was not found. Confirm that the expression in the Import declaration "artifacts/bin/GenerateFiles/Directory.Build.props" is correct, and that the file exists on disk. [/repos/installer/artifacts/tarball/src/aspnetcore.885cbe3ff7c844407404cf4e017275bcb59006df/artifacts/source-build/self/src/eng/tools/RepoTasks/RepoTasks.csproj] [/repos/installer/artifacts/tarball/Tools/source-built/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]

@MichaelSimons MichaelSimons force-pushed the issue-2280 branch 11 times, most recently from d15efbb to 288bfe6 Compare August 3, 2021 14:38
@MichaelSimons MichaelSimons marked this pull request as ready for review August 3, 2021 14:43
@MichaelSimons MichaelSimons requested a review from a team as a code owner August 3, 2021 14:43
@MichaelSimons MichaelSimons merged commit 0b62347 into dotnet:main Aug 4, 2021
@MichaelSimons MichaelSimons deleted the issue-2280 branch August 4, 2021 01:12
This was referenced Aug 4, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dseefeld dseefeld dseefeld approved these changes

@crummel crummel Awaiting requested review from crummel

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ArPow Tarball] Tier 3 - Add aspnetcore repo to arpow tarball
2 participants
@MichaelSimons @dseefeld