-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyglot Notebook: [DevExE2E][Regression] The execution results of javascript code are shown redundancy. #2979
Comments
@DonJayamanne this doesn't happen in stable. the .NET Interactive binaries are the same at this moment since we have not pushed out a new insiders release yet. What are your thoughts? |
As far as I know, no changes were made in VS Code either |
Dib doesn't persist output |
I've seen this behavior before and I don't believe it's a regression. I can't repro it until doing The repro is trivial: Another listener to the JavaScript console is added each time you do a Closing the other panes does not unhook the listeners and the redundant output will continue to be seen until the kernel is restarted. |
Is this still reproducing, we had a new release of both PolyglotNotebook and VScode |
@colombod This issue still repro on VSCodeSetup-x64-1.79.0 +dotnet-interactive-vscode-1.0.4308021.vsix. |
@colombod This issue only repro in split view. It doesn't repro when using a single view. |
Describe the bug
Using extension Polyglot Notebook in VS Code insider.
The execution results of javascript code are shown redundancy.
Detailed Repro Build info: VSCodeSetup-arm64-1.79.0-insider + dotnet-interactive-vscode-1.0.4259021.vsix
VSCode Link: https://code.visualstudio.com/insiders/#
Version: 1.79.0-insider (system setup)
Commit: a7133ae9e21e01ed204b02e17e8fc3e91dcadae7
Date: 2023-05-09T09:49:38.022Z
Electron: 22.5.1
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT arm64 10.0.25331
Sandboxed: Yes
dotnet-interactive-vscode-1.0.4259021.vsix
https://dev.azure.com/dnceng/internal/_build/results?buildId=2177104&view=artifacts&pathAsName=false&type=publishedArtifacts
sdk info: dotnet-sdk-7.0.203-win-arm64
Note:
1.It's a regression issue. It doesn't repro on VSCodeUserSetup-x64-1.78.1 + dotnet-interactive-vscode-1.0.4259021.vsix.
2.Repro VM: 172.20.30.176
Steps:
2.Ctrl+Shift+P => "Polyglot Notebook: Create new blank notebook"
3.Select "Create as .dib" ->Select "C#" -> Specify the code in cell-> execution
var x=123;
#!share --from csharp x
document.getElementById("output").innerText =
The value is ${x}.
;console.log(
The value is ${x}.
);Expected Results:
The Output show "The value is 123".
Actual Results:
The execution results of javascript code are shown redundancy.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the
#!about
magic command. ):The text was updated successfully, but these errors were encountered: