disable .NET interactive first run experience #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Dec 4, 2020
azure-pipelines.yml
Outdated
| @@ -84,8 +84,8 @@ stages: | |||
| inputs: | |||
| versionSpec: $(NodeJSVersion) | |||
|
|
|||
| - task: UseDotNet@2 | |||
| displayName: Add dotnet 3.0 | |||
| - task: UseDotNet@5 | |||
There was a problem hiding this comment.
Why not call this something like AddDotNetSDK so the naming is more durable?
There was a problem hiding this comment.
The task UseDotNet@2 should stay the same. UseDotNet is the name of an Azure DevOps thing that we don't control and @2 is their plugin/action version that we also don't control. The only thing you can and should change is the displayName field.
jonsequitur
approved these changes
Dec 4, 2020
colombod
force-pushed
the
disable_first_run
branch
from
df67c20
to
355629b
Compare
brettfo
approved these changes
Dec 4, 2020
| @@ -196,7 +196,7 @@ stages: | |||
| versionSpec: $(NodeJSVersion) | |||
|
|
|||
| - task: UseDotNet@2 | |||
| displayName: Add dotnet | |||
| displayName: Use .NET SDK | |||
There was a problem hiding this comment.
Some say Use .NET SDK and others Use .NET SDK 5.0. I'd prefer simply Use .NET SDK since the version will eventually change again, but ultimately I don't care too much.
colombod
force-pushed
the
disable_first_run
branch
from
a080fa1
to
60ce77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.