Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] SpiController and ISpiController #119

Closed
shaggygi opened this issue Dec 24, 2018 · 3 comments · Fixed by #527 or #545
Closed

[Proposal] SpiController and ISpiController #119

shaggygi opened this issue Dec 24, 2018 · 3 comments · Fixed by #527 or #545
Assignees
Labels
area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins enhancement New feature or request

Comments

@shaggygi
Copy link
Contributor

shaggygi commented Dec 24, 2018

Similar to the GpioController, there needs to be a mechanism to determine the best SpiDevice to use.

Updated 6/24/2019

Proposed Changes

1. Add New SpiController

The creation of devices with a new static helper method that attempts to pick the best SPI device for OS app is executing on. This static method will be added to a new sealed partial class respective to OS.

// SpiController.Linux.cs
public static SpiDevice Create(SpiConnectionSettings settings) => new UnixSpiDevice(settings);
// SpiController.Windows.cs
public static SpiDevice Create(SpiConnectionSettings settings) => new Windows10SpiDevice(settings);
@shaggygi
Copy link
Contributor Author

shaggygi commented Dec 24, 2018

Referencing #126

@joperezr
Copy link
Member

We can probably bundle this up with #118 since they will be super similar, so I'm fine with closing this one in favor of having only one issue for both Spi and I2c controllers.

@shaggygi shaggygi changed the title Determine structure for SpiController [Proposal] SpiController and ISpiController Jun 15, 2019
@shaggygi
Copy link
Contributor Author

@joperezr Please reopen this and assign to me. New proposal notes are in the works. Hope to post soon. Thx.

@joperezr joperezr reopened this Jun 17, 2019
@joperezr joperezr added enhancement New feature or request area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins labels Jun 17, 2019
@joperezr joperezr added this to the Future milestone Jun 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants