Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DelayHelper or similar API part of System.Device.Gpio #1249

Open
hugener opened this issue Nov 3, 2020 · 6 comments
Open

Make DelayHelper or similar API part of System.Device.Gpio #1249

hugener opened this issue Nov 3, 2020 · 6 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation Priority:3 Work that is nice to have up-for-grabs Good issue for external contributors to iot

Comments

@hugener
Copy link

hugener commented Nov 3, 2020

Timing is often important when developing device bindings, I request that System.Device.Gpio provides something like DelayHelper allowing us to use waits without having to provide our own implementation.

I am developing my own bindings, some which I don't think will live up the quality standards of Iot.Device.Bindings, but I would still like to base them on System.Device.Gpio and think that it should provide all generic functionality needed to implement a device bindings. An API for delays is missing in System.Device.Gpio and it would be nice to have one that waits the best possible way on the various platform, or just DelayHelper if that's considered good enough.

@hugener hugener added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Nov 3, 2020
@Ellerbach
Copy link
Member

DelayHelper if that's considered good enough

Yes, that's something in the radar, the request came few times and we should have it public with maybe few adjustments. So please stay a bit patient.

@hugener
Copy link
Author

hugener commented Nov 14, 2020

Great looking forward for that!
Is there are place where I can see what else is on the radar?
I found this: https://github.com/dotnet/iot/blob/master/Documentation/roadmap.md, but it wasn't updated since October 2019. Why does it mention 3.0 release when version 1.1 just went out?

I have a ton of questions ranging from testing, bugs, HW support, API- and design proposals and don't know if I should create separate question issues or rather gather them in one?

@pgrawehr
Copy link
Contributor

Yea, the roadmap is very outdated. We're just in the process of getting on track again (after the project has been sleeping a bit due to higher priority issues). Ignore that 3.0 number there, that was a project milestone that should probably never have been named like that.

It is ok to create issues, as long as it is reasonable that they can be addressed in a timely manner. That will (or rather should) of course be the case for bugs and problems. But if you ask for support for some obscure hardware that nobody has, that will probably not be helpful.

@krwq
Copy link
Member

krwq commented Nov 19, 2020

Yes when we say 3.0 we meant .NET Core 3.0 because we align releases.. Yes the doc is very old and we will publish new one once it's finalized.

@hugener to move this forward sooner I suggest to write specific place and API names you'd like this to have, once we have some agreement in the issue then we can talk about it during our weekly meeting and possibly approve and move forward with publishing these APIs. Perhaps renaming DelayHelper to Delay and some better names and namespaces would suffice here

@Ellerbach
Copy link
Member

[Triage] We will make the DelayHelper public. Work to be done on the naming and namespace to be Iot.Device.
While making changes on the helpers, would be perfect to name the Iot.Device.Common to just Iot.Device for the weather
helper.
cc @MarkCiliaVincenti

@Ellerbach Ellerbach added the up-for-grabs Good issue for external contributors to iot label Feb 25, 2021
@krwq
Copy link
Member

krwq commented Jan 12, 2023

[Triage] We should make it public but it should stay in Iot.Device.Bindings (milliseconds overloads should not be public)

@krwq krwq added the Priority:3 Work that is nice to have label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation Priority:3 Work that is nice to have up-for-grabs Good issue for external contributors to iot
Projects
None yet
Development

No branches or pull requests

4 participants