-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aspnet to baseline #278
Add aspnet to baseline #278
Conversation
(Seems to work locally for me; but not sure if I'm holding it wrong 😃) |
Need to do?
|
I cherry-picked these changes, but when I run
When I debug the failing command:
I see failures here:
The failure is because |
Changes LGTM but I just want to make sure that we can get PMI for newly binaries in |
Need to be running against .NET 5.0 Preview 8 (or later) for |
@@ -1,7 +1,8 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<Project Sdk="Microsoft.NET.Sdk.Web"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using the ".Web" project give us a superpset of dependent packages? Subset? Or partially-intersecting set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's a superset; additionally including the ASP.NET Core libraries
jitutils builds with the global installed dotnet. Maybe you just have 3.1? I normally don't notice version issues because I often have a relatively recent install (currently, something rc1). Note that #219 would onboard jitutils to arcade, which would presumably build using a local, recent dotnet, not the global one. |
I was able to run the
|
@BruceForstall - do you have any more comments or is it ready to merge? |
When I pick up this change and build I see about 135 new assemblies, mostly Microsoft.AspNetCore and Microsoft.Extensions. |
Resolves #189
@AndyAyersMS this work now?