Call CheckProcessed before enqueuing to MarkStep._methods #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
changed the title
sbomer
approved these changes
Nov 28, 2022
| // Temporarily switch to the original source for marking this method | ||
| // this is for the same reason as for tracking, but this time so that we report potential | ||
| // warnings from a better place. | ||
| MarkType (method.DeclaringType, new DependencyInfo (DependencyKind.DeclaringTypeOfCalledMethod, method), new MessageOrigin (reason.Source as IMemberDefinition ?? method)); |
There was a problem hiding this comment.
Just a note - interesting that this one is using reason.Source as the origin. Not related to your change (so I wouldn't try to address it here) but I think we have some redundancy here between the reason and origin, that will likely lead to inconsistencies.
vitek-karas
approved these changes
Nov 29, 2022
tlakollo
pushed a commit
to tlakollo/linker
that referenced
this pull request
Dec 20, 2022
* Call CheckProcessed before enqueuing to MarkStep._methods to avoid redundantly adding methods Commit migrated from dotnet@261e911
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Dec 22, 2022
…ker#3139) * Call CheckProcessed before enqueuing to MarkStep._methods to avoid redundantly adding methods Commit migrated from dotnet/linker@261e911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137
We unconditionally add a method to the MarkStep._methods queue and perform a filtering check in ProcessMethod later. This causes _methods to grow to be as large as 110 mb in some cases (see #3126 (comment)). If we instead perform the filtering check before enqueuing the method, MarkStep_methods reach a max size of ~14mb (in the same repro).