[release/7.0] Ports fixes for not crashing/haning on recursive arrays #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of the trimmer/analyzer changes from dotnet/runtime#82818. The main changes is to disallow array values in arrays - if we find an array element which is itself an array we replace it with unknown value. This stops all kinds of weird recursion behavior in the analysis and fixes cases where the tool would either crash with stack overflow or hang (exponential explosion of states). Adds the related tests as well.
1 task
|
This fixes the problem reported in dotnet/runtime#93076. |
sbomer
approved these changes
Oct 10, 2023
|
Replaced by a combined PR #3234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the trimmer/analyzer changes from dotnet/runtime#82818.
The main changes is to disallow array values in arrays - if we find an array element which is itself an array we replace it with unknown value.
This stops all kinds of weird recursion behavior in the analysis and fixes cases where the tool would either crash with stack overflow or hang (exponential explosion of states).
Adds the related tests as well.