Disable calls that require VSD. #266
Conversation
|
@erozenfeld @AndyAyersMS PTAL |
|
I've filed #267 for tracking. |
|
@erozenfeld I believe you're likely to run into this (if you haven't already) while implementing stelem support. |
|
Just realized I forgot to generate new baselines; these are pending. |
| // to the stub in a target-specific register. | ||
| throw NotYetImplementedException("VSD"); | ||
| } | ||
|
|
||
| // Ask GenIR to create return value. |
There was a problem hiding this comment.
Can you use () around the subexpressions in the if? Also might as well spell out the failure reason.
There was a problem hiding this comment.
Done on both counts.
|
Code looks good -- do you still need updated baselines? |
|
I had them, but apparently managed to debase them away. I'll either recover or regenerate them. |
|
LGTM. FYI @JosephTremoulet I think this might block getting to your nontrivial finally case from #260.
becomes
|
Such calls have a special calling convention that requires the stub address in a target-specific register. Issue #267 tracks adding support for calls that require VSD.
|
The build failure is an infrastructural problem on one of the Win64 test jobs. The other Win64 test job passed, so I'm going to go ahead and merge this PR. |
Disable calls that require VSD.
Such calls have a special calling convention that requires the stub
address in a target-specific register.
This was causing silent bad codegen during some ad-hoc testing.