-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrubbing learners (Meta issue) #2613
Comments
For instance, many learners accept R4 values and helpfully convert them to |
We also have |
The classnames themselves come in many different styles and they are surfaced through options: For example, var sdca = mlContext.BinaryClassification.Trainers.StochasticDualCoordinateAscent(
new SdcaBinaryTrainer.Options { NumberOfThreads = 1 });
var fastTree = mlContext.BinaryClassification.Trainers.FastTree(
new FastTreeBinaryClassificationTrainer.Options { NumberOfThreads = 1 }); These class names should have a standard grammar. |
We need to clean our API for learners.
This includes following things:
No protected fields/members/method in public classes. Only private protected.
Learner class is sealed.
The trainer name types should follow the names used in the contexts (see The trainer name types should follow the names used in the contexts #2172)
ModelPameters for this Learner is also clean. (sealed, public documentation, no public constructor)
Options cleaning:
LearnerInputBase*
)int
but only accepts specific values #2521) or accept array of ints as a string separated by commapublic string CustomGains = "0,3,7,15,31";
/// <param name="labelColumnName">The name of the label column.</param>
/// <param name="featureColumnName">The name of the feature column.</param>
NumberOfIterations
,NumberOfThreads
,LearningRate
,L2Regularization
,L1Regularization
no (
MaxIterations
,NumIterations
,NumThreads
,L2Weight
,L1Weight
)ignore for now:
Everything public has proper documentation.
We have samples of how use base call to trainer (no options) and call with options.
We have baseline tests for learner.
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/general-naming-conventions#using-abbreviations-and-acronyms
`
The text was updated successfully, but these errors were encountered: