Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI TimePicker needs to expose additional properties #16095

Open
Stedy59 opened this issue Jul 11, 2023 · 5 comments
Open

WinUI TimePicker needs to expose additional properties #16095

Stedy59 opened this issue Jul 11, 2023 · 5 comments
Labels
area-controls-datetimepicker DatePicker, TimePicker platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@Stedy59
Copy link

Stedy59 commented Jul 11, 2023

Description

image

The time selection popup portion of the control does not inherit any Font properties, [Family, Size, Color]

Also, there is no property exposed to allow the selected time background color change. I also attempted to modify the base control's resource dictionary. but none of the popup value "keys" responded to change.

Steps to Reproduce

  1. Create a .net Maui app

  2. Add a TimePicker to the view

                     `<TimePicker
     		FontFamily="Cartoon"
     		FontSize="22"
     		HorizontalOptions="Center"
     		TextColor="Red"/>`
    

Link to public reproduction project repository

n/a - just create a new project

Version with bug

8.0.0-preview.5.8529

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows SDK - all

Did you find any workaround?

no - as stated, even creating a handler, the WinUI control seemed to ignore the changes!

Relevant log output

No response

@Stedy59 Stedy59 added the t/bug Something isn't working label Jul 11, 2023
@jsuarezruiz jsuarezruiz added the area-controls-datetimepicker DatePicker, TimePicker label Jul 12, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 12, 2023
@jfversluis
Copy link
Member

no - as stated, even creating a handler, the WinUI control seemed to ignore the changes!

What is the handler that you have tried?

Did this work in .NET 7?

@jfversluis jfversluis added the s/needs-info Issue needs more info from the author label Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Hi @Stedy59. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@Stedy59
Copy link
Author

Stedy59 commented Jul 12, 2023

@jfversluis

I will create a repo that include my custom Handler/Mapper. Please look at this...

#16094 (comment)

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-info Issue needs more info from the author labels Jul 12, 2023
@Stedy59
Copy link
Author

Stedy59 commented Jul 20, 2023

no - as stated, even creating a handler, the WinUI control seemed to ignore the changes!

What is the handler that you have tried?

Did this work in .NET 7?

This has never worked properly on any version I have used.

Here is a repo of the Android/WinUI "TimePicker" handler I mentioned earlier... Thank you for all you do!

https://github.com/Stedy59/MauiTimeSelector

@samhouts samhouts changed the title .NET 8.0 Preview 5/6 - WinUI TimePicker needs to expose additional properties WinUI TimePicker needs to expose additional properties Aug 2, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Aug 4, 2023
@XamlTest
Copy link

XamlTest commented Aug 4, 2023

Verified this on Visual Studio Enterprise 17.7.0 Preview 6.0. Repro on Windows 11 .NET 8 with below Project:
16095.zip

@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 11, 2024
@jsuarezruiz jsuarezruiz removed the s/needs-attention Issue has more information and needs another look label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-datetimepicker DatePicker, TimePicker platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants