Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Modify our CI Template Tests so that TreatWarningsAsErrors is enabled #16709

Closed
PureWeen opened this issue Aug 11, 2023 · 0 comments · Fixed by #16766
Closed

[Testing] Modify our CI Template Tests so that TreatWarningsAsErrors is enabled #16709

PureWeen opened this issue Aug 11, 2023 · 0 comments · Fixed by #16766
Assignees
@pjcollins
Labels
area-testing Unit tests, device tests fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 t/housekeeping ♻︎ Task neither bug nor feature but something that needs to be done in support of either
Milestone
.NET 8 GA

Comments

@PureWeen
Copy link
Member

Description

Our templates should have zero warnings.

If we get into a state where the templates have any warnings it means something has been missed and we need to remedy that state.
@PureWeen PureWeen added this to the .NET 8 GA milestone Aug 11, 2023
@Eilon Eilon added the area-testing Unit tests, device tests label Aug 11, 2023
@pjcollins pjcollins self-assigned this Aug 15, 2023
@pjcollins pjcollins mentioned this issue Aug 15, 2023
Merged
@samhouts samhouts added the Task neither bug nor feature but something that needs to be done in support of either label Aug 15, 2023
pjcollins added a commit that referenced this issue Aug 15, 2023
@pjcollins
[tests] Enable TreatWarningsAsErrors=true (#16766)
6fd85a1 
Fixes: #16709

Sets `TreatWarningsAsErrors` to true when building template and sample
projects to ensure that warnings are not missed.
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Aug 15, 2023
rmarinho pushed a commit that referenced this issue Aug 19, 2023
@pjcollins @rmarinho
[tests] Enable TreatWarningsAsErrors=true (#16766)
ec5489c 
Fixes: #16709

Sets `TreatWarningsAsErrors` to true when building template and sample
projects to ensure that warnings are not missed.
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjcollins pjcollins

Labels
area-testing Unit tests, device tests fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 t/housekeeping ♻︎ Task neither bug nor feature but something that needs to be done in support of either
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging a pull request may close this issue.

[tests] Enable TreatWarningsAsErrors=true pjcollins/maui
4 participants
@Eilon @pjcollins @PureWeen @samhouts