Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that viewport calculations for iOS ScrollView account for content insets #18277

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Ensure that viewport calculations for iOS ScrollView account for content insets #18277

merged 2 commits into from
Oct 24, 2023

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Oct 24, 2023

Description of Change

If the content of the ScrollView is smaller than the viewport, the content size needs to expand to fill the viewport. However, when calculating the viewport size, we need to account for content insets (from, e.g., safe area insets); otherwise, the content size of the ScrollView is set a bit too large, and the content will be scrollable.

Issues Fixed

Fixes #17224

@hartez hartez marked this pull request as ready for review October 24, 2023 19:03
@hartez hartez requested a review from a team as a code owner October 24, 2023 19:03
@PureWeen PureWeen merged commit 0cb5d80 into net8.0 Oct 24, 2023
47 checks passed
@PureWeen PureWeen deleted the fix-17224 branch October 24, 2023 22:34
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2.2

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6633313703

@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
@hartez hartez mentioned this pull request Oct 25, 2023
Closed
@mattleibow mattleibow mentioned this pull request Nov 7, 2023
Closed
PureWeen added a commit that referenced this pull request Nov 7, 2023
@PureWeen
Revert "Ensure that viewport calculations for iOS ScrollView account …
39f1a7b 
…for content insets (#18277)"

This reverts commit 0cb5d80.
@PureWeen PureWeen mentioned this pull request Nov 7, 2023
Merged
PureWeen added a commit that referenced this pull request Nov 7, 2023
@PureWeen
Revert "Ensure that viewport calculations for iOS ScrollView account …
1ebb238 
…for content insets (#18277)" (#18579)

This reverts commit 0cb5d80.
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@PureWeen
Revert "Ensure that viewport calculations for iOS ScrollView account …
d04d044 
…for content insets (#18277)"

This reverts commit 0cb5d80.
PureWeen added a commit that referenced this pull request Nov 9, 2023
@github-actions @PureWeen
Revert "Ensure that viewport calculations for iOS ScrollView account …
0d31e65 
…for content insets (#18277)" (#18646)

This reverts commit 0cb5d80.

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
@mattleibow
Copy link
Member

This was reverted as it caused #18513

However, there is a new fix for both issues in #18586

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hartez @PureWeen @mattleibow @samhouts