Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/8.0.0-rc.1.9171] XAMLC is currently throwing exceptions in RC1 that don't appear to have been throwing in PReview7 #17333

Closed
PureWeen opened this issue Sep 12, 2023 · 0 comments · Fixed by #17364
Closed

[regression/8.0.0-rc.1.9171] XAMLC is currently throwing exceptions in RC1 that don't appear to have been throwing in PReview7 #17333

PureWeen opened this issue Sep 12, 2023 · 0 comments · Fixed by #17364
Assignees
@StephaneDelcroix
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working
Milestone
.NET 8 GA

Comments

@PureWeen
Copy link
Member

PureWeen commented Sep 12, 2023 •
edited by samhouts
Loading

Description

XAMLC is currently throwing exceptions in RC1 that don't appear to have been throwing in PReview7

/Users/shneuvil/Downloads/AXamlCStyleError/AXamlCStyleError/Resources/Styles/DefaultStyles.xaml: Error: Collection was modified; enumeration operation may not execute. (AXamlCStyleError) XamlC

Steps to Reproduce

Download this sample based off of https://github.com/davidortinau/ControlGallery
AXamlCStyleError.zip

Try to compile it

Link to public reproduction project repository

https://github.com/davidortinau/ControlGallery

Version with bug

8.0.0-rc.1.9171

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.0-preview.7.8842

Affected platforms

iOS, Android, Windows, macOS

Affected platform versions

No response

Did you find any workaround?

Remove XAMLC attribute from failing files

Relevant log output

No response
@PureWeen PureWeen added the t/bug Something isn't working label Sep 12, 2023
@PureWeen PureWeen added i/regression This issue described a confirmed regression on a currently supported version area-xaml XAML, CSS, Triggers, Behaviors labels Sep 12, 2023
@PureWeen PureWeen added this to the .NET 8 GA milestone Sep 12, 2023
@samhouts samhouts changed the title XAMLC is currently throwing exceptions in RC1 that don't appear to have been throwing in PReview7 [regression/8.0.0-rc.1.9171] XAMLC is currently throwing exceptions in RC1 that don't appear to have been throwing in PReview7 Sep 12, 2023
StephaneDelcroix added a commit that referenced this issue Sep 14, 2023
@StephaneDelcroix
[X] fix CollectionItems enumeration
6ee2fe9 
- fixes #17333
@StephaneDelcroix StephaneDelcroix mentioned this issue Sep 14, 2023
Merged
StephaneDelcroix added a commit that referenced this issue Sep 14, 2023
@StephaneDelcroix
[X] fix CollectionItems enumeration
42e47d1 
- fixes #17333
PureWeen pushed a commit that referenced this issue Sep 15, 2023
@StephaneDelcroix
[X] fix CollectionItems enumeration (#17364)
671bf15 
- fixes #17333
samhouts pushed a commit that referenced this issue Sep 17, 2023
@mattleibow @dustin-wojciechowski
@tj-devel709 @PureWeen @github-actions @hartez @StephaneDelcroix @jfversluis @dependabot
Merge main into net8.0 (#17419)
77f0def 
* Removed references to GraphicsTester.Skia.Tizen from Maui-dev and Maui-vscode sln files. (#17334)

* Enable requesting the full preview size on iOS drag shadow & iOS and Windows Samples (#17282)

* Enable requesting the full preview size on iOS drag shadow

* Add in windows drag and drop sample

* Move itemssource class into main class

---------

Co-authored-by: TJ Lambert (HE/HIM/HIS) <antlambe@microsoft.com>

* Wait for parent to get set before realizing titleview (#17360)

* [create-pull-request] automated change (#17362)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Make the taps work on all platforms (#17325)

* Added integration test for maui blazor maccatalyst codesign verification. (#17331)

* Added integration test for maui blazor maccatalyst codesign verification.

* Created new Codesign class and moved SearchForExpectedEntitlements to it.

* Updated to DotNetCurrent

* [C] Replace value with same specificity (#17365)

We don't have a test for that

-fixes #17357

* Enable Mac Catalyst Controls Device Tests in CI (#17229)

* Enable Mac Catalyst Controls Device Tests in CI

* Disable failing tests

* [C] Port the specificity concept to Bindings (#17215)

* [C] Port the specificity concept to Bindings

Allow having multiple layers of Bindings, useful for e.g.
AppThemeBinding, Style, VSM

- fixes #16538

* test for 17354

* Revert changes to setting context and add tests (#17348)

* Remove macOS as that is not installed by default (#17379)

* Increase timeouts to 4 hours (#17386)

* Bump the aspnetcore group with 7 updates (#17345)

Bumps the aspnetcore group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.AspNetCore.Components.WebView](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.JSInterop](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.AspNetCore.Components.Web](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.AspNetCore.Authentication.Facebook](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.AspNetCore.Authentication.Google](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |
| [Microsoft.AspNetCore.Authentication.MicrosoftAccount](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` |


Updates `Microsoft.AspNetCore.Authorization` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.AspNetCore.Components.WebView` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.JSInterop` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.AspNetCore.Components.Web` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.AspNetCore.Authentication.Facebook` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.AspNetCore.Authentication.Google` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

Updates `Microsoft.AspNetCore.Authentication.MicrosoftAccount` from 7.0.10 to 7.0.11
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Authorization
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.AspNetCore.Components.WebView
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.JSInterop
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.AspNetCore.Components.Web
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.AspNetCore.Authentication.Facebook
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.AspNetCore.Authentication.Google
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
- dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aspnetcore
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [create-pull-request] automated change (#17388)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [X] fix CollectionItems enumeration (#17364)

- fixes #17333

* passing test for #16960 (#17397)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
Co-authored-by: TJ Lambert (HE/HIM/HIS) <antlambe@microsoft.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@StephaneDelcroix StephaneDelcroix mentioned this issue Sep 22, 2023
Closed
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephaneDelcroix StephaneDelcroix

Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging a pull request may close this issue.

[X] fix CollectionItems enumeration dotnet/maui
3 participants
@StephaneDelcroix @PureWeen @samhouts