Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross TabBar navigation broken on iOS #22570

Closed
albyrock87 opened this issue May 22, 2024 · 4 comments · May be fixed by #22655
Closed

Cross TabBar navigation broken on iOS #22570

albyrock87 opened this issue May 22, 2024 · 4 comments · May be fixed by #22655
Labels
platform/iOS 🍎 t/bug Something isn't working

Comments

@albyrock87
Copy link
Contributor

albyrock87 commented May 22, 2024

Description

On iOS, using TabBar and navigating to a new Tab also pushing a page onto the navigation stack does not work:

  • No exception is thrown
  • Task is not completed
var shell = Shell.Current;
try
{
    // "main" is the `TabBar`
    // "Foo" is a different `ShellContent`
    // "Bar" is a page registered in the `Routing`
    await shell.GoToAsync("//main/Foo/Bar");
}
catch (Exception ex)
{ 
    // Add breakpoint here => not hit
    Console.WriteLine(ex.Message);
}
finally
{
    // Add breakpoint here => not hit
    Console.WriteLine("Finally");
}

Steps to Reproduce

No response

Link to public reproduction project repository

https://github.com/albyrock87/maui-shell-issues/blob/main/MainPage.xaml.cs#L14-L28

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS 17.2

Did you find any workaround?

No workaround.

Relevant log output

No response

@albyrock87 albyrock87 added the t/bug Something isn't working label May 22, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@albyrock87
Copy link
Contributor Author

This is probably a duplicate of #16568 but the public repository I've attached to reproduce the issue is less complicate to look at.

@kubaflo
Copy link
Contributor

kubaflo commented May 26, 2024

Hi @albyrock87, thanks for your repository! I've made some investigation and this issue is related, but not the same as #16568

The later one is about the navigation inside the 'more' tab and yours is about the navigating between the visible-tabs-in-toolbar. I have a fix for your issue: #22655

@albyrock87
Copy link
Contributor Author

albyrock87 commented May 26, 2024

@kubaflo I also have a fix for my issue: #22574
anyway, I guess two is better than one 😉
And actually yours looks better (hoping it doesn't cause issues on other platforms).
Thanks for looking into it, I appreciate!

kubaflo added a commit to kubaflo/maui that referenced this issue May 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
kubaflo added a commit to kubaflo/maui that referenced this issue Jul 2, 2024
kubaflo added a commit to kubaflo/maui that referenced this issue Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants