Cross TabBar navigation broken on iOS - Fix #22655
Open
+88
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
added
platform/iOS 🍎
area-controls-shell
rmarinho
approved these changes
May 27, 2024
rmarinho
requested changes
May 27, 2024
|
@rmarinho I think now should be good :) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
Jun 4, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jul 5, 2024
| @@ -115,7 +115,11 @@ public ShellNavigationManager(Shell shell) | |||
| modalStackPreBuilt = true; | |||
|
|
|||
| bool? isAnimated = (nextActiveSection != currentShellSection) ? false : animate; | |||
| await nextActiveSection.GoToAsync(navigationRequest, parameters, _shell.FindMauiContext()?.Services, isAnimated, isRelativePopping); | |||
|
|
|||
| await _shell.Dispatcher.DispatchAsync(() => | |||
There was a problem hiding this comment.
I'm curious to investigate this a bit further and see if we can base this fix on something more deterministic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #22570
Fixes #18193
Fixes #16568
before.mp4
fixed.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-01.at.13.09.33.mp4