Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation stuck on iOS when pushing on hidden tab section in TabBar #22574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix navigation stuck on iOS when pushing on hidden tab section in TabBar #22574

wants to merge 1 commit into from
+10 −4

Conversation

albyrock87
Copy link
Contributor

Description of Change

On iOS, the view controller DidShowViewController will not be triggered until the Tab inside TabBar becomes visible.
The code is waiting on that before switching to the new Tab, this causes a race condition.
So in this specific case, we have to complete the task immediately instead of waiting for DidShowViewController.

Issues Fixed

Fixes #16568

@albyrock87 albyrock87 requested a review from a team as a code owner May 22, 2024 11:32
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@albyrock87
Copy link
Contributor Author

Build is failing for an unrelated test:

Error Message:
   Shape should not be alive!
  Stack Trace:
     at Microsoft.Maui.UnitTests.Views.ShapeTests.ShapeFillDoesNotLeak() in /_/src/Core/tests/UnitTests/Views/ShapeTests.cs:line 46

@albyrock87 albyrock87 mentioned this pull request May 26, 2024
Closed
@jsuarezruiz jsuarezruiz requested a review from PureWeen May 31, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-navigation NavigationPage community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS App Actions Navigation does not navigate to subpages correctly
2 participants
@albyrock87 @jsuarezruiz