-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontImage markup extension doesn't allow AppThemeBinding #23347
Comments
Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! Open similar issues:
|
I think this was discussed in the past already, but it looks like the FontImageExtension could be removed, and you could use the FontImageSource element with a markup syntax |
The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...) For convenience, the element syntax can be used as a markup syntax {FontImagesource} - fixes #23347
as a workaround, using {FontImageSource} works. Once #23657 is merged, it also becomes the recommended way, as {fontImage will be deprecated} |
The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...) For convenience, the element syntax can be used as a markup syntax {FontImagesource} - fixes #23347
@mgoertz-msft @DianaSoltani can we get a code analyzer fix for this and work it into Upgrade Assistant? |
I would start by marking [Obsolete(...)] with a message of what to use instead. All these one-off analyzers/codefixers aren't cheap since we do not have a good infrastructure for manipulating XAML. We can add that to the score card. :) |
Description
This works in Hot Reload, but won't compile.
This works everywhere:
Steps to Reproduce
No response
Link to public reproduction project repository
No response
Version with bug
8.0.61 SR6.1
Is this a regression from previous behavior?
Not sure, did not test other versions
Last version that worked well
Unknown/Other
Affected platforms
iOS
Affected platform versions
No response
Did you find any workaround?
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: