Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MAUI trimming safe ✂️ #355

Closed
marek-safar opened this issue Feb 23, 2021 · 3 comments
Closed

Make MAUI trimming safe ✂️ #355

marek-safar opened this issue Feb 23, 2021 · 3 comments
Labels
area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) proposal/open

Comments

@marek-safar
Copy link

As part of the .NET6 effort we are making the .NET Runtime trimming safe allow developers to annotate their libraries to be also trimming safe. As MAUI is one of the primary workloads which will always use linker and cares about the size it's important to resolve any linker warnings which the developers would experience when enabling linker analyzers in their apps to be able to trim their apps fully.

This will partially depend on the work done for Apple, Android and WinUI SDKs but it's not blocked by them.

@Redth
Copy link
Member

Redth commented Feb 23, 2021

There are a few things that will immediately help us progress here. We are moving to a more code/API based approach to registering things like handlers instead of scanning for assembly level attributes when assemblies are loaded. In areas where we still want (or need) to support these types of scenarios we can move towards using source code generators to generate the api invocations so that the linker can still be aware of usages and have them not linked out.

Agree overall, being trimming safe is a priority for MAUI.

@marek-safar
Copy link
Author

Using source generators is certainly a step in the right direction. You can use the tooling to identify linker unsafe code today if you need to.

@Redth Redth added the Epic Groups multiple user stories. Can be grouped under a theme. label Jul 8, 2021
@Redth Redth changed the title Make MAUI trimming safe Make MAUI trimming safe ✂️ Jul 8, 2021
@Redth Redth removed the Epic Groups multiple user stories. Can be grouped under a theme. label Aug 5, 2021
@Eilon Eilon added the area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) label Oct 18, 2021
@Redth
Copy link
Member

Redth commented Nov 5, 2021

Closed - tracking in #1962

@Redth Redth closed this as completed Nov 5, 2021
rookiejava pushed a commit to rookiejava/maui that referenced this issue Jan 27, 2022
* [Tizen] Fix BlazorWebView build error

* [Tizen] Update tizen handler
rookiejava pushed a commit to rookiejava/maui that referenced this issue Feb 4, 2022
* [Tizen] Fix BlazorWebView build error

* [Tizen] Update tizen handler
rookiejava pushed a commit to rookiejava/maui that referenced this issue Feb 8, 2022
* [Tizen] Fix BlazorWebView build error

* [Tizen] Update tizen handler
rookiejava pushed a commit to rookiejava/maui that referenced this issue Feb 10, 2022
* [Tizen] Fix BlazorWebView build error

* [Tizen] Update tizen handler
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) proposal/open
Projects
None yet
Development

No branches or pull requests

3 participants