Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Wrong initial cursor position in Editor #4089

Closed
jsuarezruiz opened this issue Jan 12, 2022 · 3 comments · Fixed by #5648
Closed

[Windows] Wrong initial cursor position in Editor #4089

jsuarezruiz opened this issue Jan 12, 2022 · 3 comments · Fixed by #5648
Labels
area-controls-editor Editor area-controls-entry Entry fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! good first issue Good for newcomers platform/windows 🪟 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@jsuarezruiz
Copy link
Contributor

Description

Start in the middle of the Editor's height:
image

Steps to Reproduce

  1. Download ControlGallery.zip
  2. Try to navigate to the "Editor sample".

Version with bug

Preview 11

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows 10 1909

Did you find any workaround?

No response

Relevant log output

No response

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jan 12, 2022
@shimingsg shimingsg added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Feb 16, 2022
@shimingsg
Copy link

shimingsg commented Feb 16, 2022

Verified Repro with windows. Repro project
4089.zip

@jsuarezruiz jsuarezruiz added the good first issue Good for newcomers label Feb 25, 2022
@bricelam
Copy link
Contributor

bricelam commented Mar 18, 2022

Is this by design? The cross-platform default is currently Center:

public static readonly BindableProperty VerticalTextAlignmentProperty =
BindableProperty.Create(nameof(ITextAlignmentElement.VerticalTextAlignment), typeof(TextAlignment), typeof(ITextAlignmentElement), TextAlignment.Center);

You can change it to Start if you want it top-aligned.

<Editor 
    VerticalTextAlignment="Start"
    Text="This should be on the top"
    HeightRequest="100"/>

@bricelam
Copy link
Contributor

bricelam commented Mar 18, 2022

Hmm, looks like Android and iOS do indeed default to the top. Maybe the line above should be changed to Start?

@Redth Redth added this to the 6.0.300 milestone Mar 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2022
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Feb 17, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-editor Editor area-controls-entry Entry fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! good first issue Good for newcomers platform/windows 🪟 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants