Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexLayout RowReverse doesn't work Properly #7756

Closed
ShariatPanah opened this issue Jun 4, 2022 · 1 comment · Fixed by #13936
Closed

FlexLayout RowReverse doesn't work Properly #7756

ShariatPanah opened this issue Jun 4, 2022 · 1 comment · Fixed by #13936
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! layout-flex FlexLayout issues platform/android 🤖 t/bug Something isn't working
Milestone
.NET 8 + Servicing

Comments

@ShariatPanah
Copy link

ShariatPanah commented Jun 4, 2022 •
edited
Loading

Description

Actually this bug still persists on Xamarin.Forms and its not a surprise that .Net Maui has the same bug. i already submitted this issue on Xamarin at #15085 without a luck!
So when you change the direction from Row to RowReverse the layout messes up, maybe it has something to do with ScrollView or I'm just doing something wrong?

Steps to Reproduce

I have attached the sample, please just run it to see the problem, so open MainPage.xaml I have set the Direction of FlexLayout to RowReverse and you can see the frames overlapping each other (I think it has the exact same effect for ColumnReverse, please check that too)
FlexLayoutBug.zip

and here are some screenshots:

With Direction set to Row:
FlexLayout 01

With Direction set to RowReverse:
FlexLayout 02

Version with bug

6.0 Release Candidate 3

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 10.0

Did you find any workaround?

No response

Relevant log output

No response
@ShariatPanah ShariatPanah added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jun 4, 2022
@kristinx0211 kristinx0211 added s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Jun 6, 2022
@kristinx0211
Copy link

can be reproduced on android 12 with vs 17.3.0 Preview 3.0 [32605.41.main].

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jun 6, 2022
@hartez hartez added the layout-flex FlexLayout issues label Oct 9, 2022
hartez added a commit that referenced this issue Mar 14, 2023
@hartez
Adjust flex item position to account for reversal when laying out unc…
5330943 
…onstrained

Fixes #7756
@hartez hartez mentioned this issue Mar 14, 2023
Merged
@hartez hartez self-assigned this Mar 14, 2023
@hartez hartez removed their assignment Apr 3, 2023
@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
hartez added a commit that referenced this issue Apr 10, 2023
@hartez
Adjust flex item position to account for reversal when laying out unc…
556858f 
…onstrained

Fixes #7756
PureWeen pushed a commit that referenced this issue May 15, 2023
@hartez
Adjust flex item position to account for reversal when laying out unc…
8150d01 
…onstrained (#13936)

* Adjust flex item position to account for reversal when laying out unconstrained
Fixes #7756

* Add automated tests

* Auto-format source code

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
rmarinho pushed a commit that referenced this issue May 30, 2023
@hartez @rmarinho
Adjust flex item position to account for reversal when laying out unc…
eff3c8f 
…onstrained (#13936)

* Adjust flex item position to account for reversal when laying out unconstrained
Fixes #7756

* Add automated tests

* Auto-format source code

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
@ghost ghost locked as resolved and limited conversation to collaborators Jun 14, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Jun 21, 2023
@samhouts samhouts added this to the .NET 8 + Servicing milestone Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! layout-flex FlexLayout issues platform/android 🤖 t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 + Servicing
Development

Successfully merging a pull request may close this issue.

Adjust flex item position to account for reversal when laying out unconstrained dotnet/maui
5 participants
@Eilon @hartez @samhouts @ShariatPanah @kristinx0211