Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom FlyoutIcon visible although FlyoutBehavior set to disabled on Android an IOS #9037

Open
FM1973 opened this issue Jul 28, 2022 · 4 comments · May be fixed by #20087
Open

Custom FlyoutIcon visible although FlyoutBehavior set to disabled on Android an IOS #9037

FM1973 opened this issue Jul 28, 2022 · 4 comments · May be fixed by #20087
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@FM1973
Copy link

FM1973 commented Jul 28, 2022

Description

When I add a custom FlyoutIcon to shell, the icon is visible on a page although I´ve set Shell.FlyoutBehavior="Disabled" on the page and inside shellContent.
This happens on Android (v12 in my case) and iOS (15 in my case).
When you toch the icon on iOS, nothing happens...
When you do the same an Andoid an error occurs (No drawer view found with gravity LEFT).

When I remove the custom icon, all works as expected (hamburger menu not being displayed).

Steps to Reproduce

  1. Create a new maui app
  2. Create a shell with some shell contents
  3. For one shell content set Shell.FlyoutBehavior="Disabled"
  4. Set this shell content as the first item (start page)
  5. Add a custom FlyoutIcon (FlyoutIcon="flyout_icon.png")
  6. Start the app and the icon is being displayed although it shouldn´t
  7. Stop the app and remove the custom icon
  8. Start the app and the hamburger menu icon is not being displayed as it sould

Expected: The custom flyout icon should not be displayed on pages with Shell.FlyoutBehavior="Disabled"
Actual outcome: The custom flyout is being displayed on pages with Shell.FlyoutBehavior="Disabled"

Version with bug

6.0.400

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

iOS 15, Android 12

Did you find any workaround?

No response

Relevant log output

No response

@FM1973 FM1973 added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jul 28, 2022
@FM1973
Copy link
Author

FM1973 commented Jul 28, 2022

One more thing I noticed now: a custom flyouticon replaces even the backbutton. Don´t think this is intended.

@jfversluis jfversluis added area-controls-shell Shell Navigation, Routes, Tabs, Flyout and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Aug 1, 2022
@jfversluis jfversluis added this to the Future milestone Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

We've moved this issue to the Future milestone. This means that it is not going to be worked on for the coming release. We will reassess the issue following the current release and consider this item at that time.

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 4, 2023
@Zhanglirong-Winnie
Copy link
Collaborator

Verified this issue with Visual Studio Enterprise 17.8.0 Preview 1.0. Can repro on iOS and android platform.

@kubaflo kubaflo linked a pull request Jan 22, 2024 that will close this issue
@kubaflo
Copy link
Collaborator

kubaflo commented Jan 22, 2024

@jfversluis @Zhanglirong-Winnie @FM1973 I could also replicate this bug on both Android and iOS. Here's the PR of the fix that I propose: #20087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants