Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom FlyoutIcon visible although FlyoutBehavior set to disabled on Android an IOS #9037

Closed
FM1973 opened this issue Jul 28, 2022 · 4 comments · Fixed by #20087
Closed

Custom FlyoutIcon visible although FlyoutBehavior set to disabled on Android an IOS #9037

FM1973 opened this issue Jul 28, 2022 · 4 comments · Fixed by #20087
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.80 fixed-in-9.0.0-preview.7.24407.4 platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
Backlog

Comments

@FM1973
Copy link

FM1973 commented Jul 28, 2022

Description

When I add a custom FlyoutIcon to shell, the icon is visible on a page although I´ve set Shell.FlyoutBehavior="Disabled" on the page and inside shellContent.
This happens on Android (v12 in my case) and iOS (15 in my case).
When you toch the icon on iOS, nothing happens...
When you do the same an Andoid an error occurs (No drawer view found with gravity LEFT).

When I remove the custom icon, all works as expected (hamburger menu not being displayed).

Steps to Reproduce

  1. Create a new maui app
  2. Create a shell with some shell contents
  3. For one shell content set Shell.FlyoutBehavior="Disabled"
  4. Set this shell content as the first item (start page)
  5. Add a custom FlyoutIcon (FlyoutIcon="flyout_icon.png")
  6. Start the app and the icon is being displayed although it shouldn´t
  7. Stop the app and remove the custom icon
  8. Start the app and the hamburger menu icon is not being displayed as it sould

Expected: The custom flyout icon should not be displayed on pages with Shell.FlyoutBehavior="Disabled"
Actual outcome: The custom flyout is being displayed on pages with Shell.FlyoutBehavior="Disabled"

Version with bug

6.0.400

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

iOS 15, Android 12

Did you find any workaround?

No response

Relevant log output

No response
@FM1973 FM1973 added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jul 28, 2022
@FM1973
Copy link
Author

FM1973 commented Jul 28, 2022

One more thing I noticed now: a custom flyouticon replaces even the backbutton. Don´t think this is intended.

@jfversluis jfversluis added area-controls-shell Shell Navigation, Routes, Tabs, Flyout and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Aug 1, 2022
@jfversluis jfversluis added this to the Future milestone Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

We've moved this issue to the Future milestone. This means that it is not going to be worked on for the coming release. We will reassess the issue following the current release and consider this item at that time.

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 4, 2023
@Zhanglirong-Winnie
Copy link

Verified this issue with Visual Studio Enterprise 17.8.0 Preview 1.0. Can repro on iOS and android platform.

@kubaflo kubaflo mentioned this issue Jan 22, 2024
Merged
@kubaflo
Copy link
Contributor

kubaflo commented Jan 22, 2024 •
edited
Loading

@jfversluis @Zhanglirong-Winnie @FM1973 I could also replicate this bug on both Android and iOS. Here's the PR of the fix that I propose: #20087

kubaflo added a commit to kubaflo/maui that referenced this issue Jan 26, 2024
@kubaflo
Hide FlyoutIcon when FlyoutBehavior set to disabled (dotnet#9037)
c431cdd
@github-actions github-actions bot mentioned this issue May 20, 2024
Open
kubaflo added a commit to kubaflo/maui that referenced this issue Jun 1, 2024
@kubaflo
Hide FlyoutIcon when FlyoutBehavior set to disabled (dotnet#9037)
cab0da5
kubaflo added a commit to kubaflo/maui that referenced this issue Jun 1, 2024
@kubaflo
Revert "Hide FlyoutIcon when FlyoutBehavior set to disabled (dotnet#9037
4201c75 
)"

This reverts commit cab0da5.
@github-actions github-actions bot mentioned this issue Jun 12, 2024
Open
kubaflo added a commit to kubaflo/maui that referenced this issue Jul 16, 2024
@kubaflo
Hide FlyoutIcon when FlyoutBehavior set to disabled (dotnet#9037)
87417f1
kubaflo added a commit to kubaflo/maui that referenced this issue Jul 16, 2024
@kubaflo
Revert "Hide FlyoutIcon when FlyoutBehavior set to disabled (dotnet#9037
4ca55a4 
)"

This reverts commit cab0da5.
PureWeen pushed a commit that referenced this issue Jul 17, 2024
@kubaflo @jsuarezruiz
Hide FlyoutIcon when FlyoutBehavior set to disabled (#20087)
1b7bfe3 
* Hide FlyoutIcon when FlyoutBehavior set to disabled (#9037)

* Added a UITest

* Revert "Hide FlyoutIcon when FlyoutBehavior set to disabled (#9037)"

This reverts commit cab0da5.

* Fixes

* Update Issue20166.cs

* Added pending snapshots

* Added a test category

* Renamed test

---------

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.80 fixed-in-9.0.0-preview.7.24407.4 platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Hide FlyoutIcon when FlyoutBehavior set to disabled kubaflo/maui
5 participants
@jfversluis @samhouts @FM1973 @kubaflo @Zhanglirong-Winnie