Fix Layout issues with the details page on Flyout #12909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
mikeparker104
added
the
partner/cat 😻
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
PureWeen
added
the
backport/suggested
PureWeen
removed
the
backport/suggested
|
🚨 API change(s) detected @davidbritch FYI |
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hartez
approved these changes
May 8, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Fix Flyout page on iPad * Update FlyoutPageTests.cs * - use better override for rotation * - fix bounds for phone * - modify ipad flyoutpage to open over content * - fix click off frame * - fix a few issues with flyoutpage layout on ipad * -fix RTL * - fix pan offset calculations * - fix width check * - add bool to allow users to toggle behavior * Auto-format source code --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When we moved over to MAUI we switched to using
PhoneFlyoutPageRendererfor both iPad and Phone in order to simplify and make the behavior symmetric. ThePhoneFlyoutPageRendererunfortunately had more short comings then I'd anticipated so this PR fixes a number of them.PhoneFlyoutPageRendererdidn't really work withSplitmode at all, so this takes into account different measuring/arranging based on if you're in SplitMode.Formswhere the popover goes over the details instead of shifting the details view over.If time allows for it we'll shift all this back into
coreand then shell and non-shell can just use the same code.Issues Fixed
Fixes #7520
Fixes #10291
Docs Notes
XF. If you're on an iPhone it'll push the content over when the popup opens and on an iPad the popver will overlap.PhoneFlyoutPageRendererFlyoutOverlapsDetailsInPopoverMode which allows users to toggle between the two behaviors if they want to influence how it works.