Adjust index path for cell reuseid in carouselview #15140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CarouselView uses a fake number of items for looping effect like android does, we also need to correct the index used in the base items controller to be the actual item index, not the looped one.
This was also masking the public api txt warnings, but have added the unshipped api's as well.
rmarinho
approved these changes
May 18, 2023
expensivecow
pushed a commit
to expensivecow/maui
that referenced
this pull request
May 22, 2023
* Adjust index path for cell reuseid in carouselview Since CarouselView uses a fake number of items for looping effect like android does, we also need to correct the index used in the base items controller to be the actual item index, not the looped one. * Fix return * Remove ifdef for net8, we are net8 This was also masking the public api txt warnings, but have added the unshipped api's as well.
expensivecow
pushed a commit
to expensivecow/maui
that referenced
this pull request
May 22, 2023
)" This reverts commit 0fd128d.
expensivecow
pushed a commit
to expensivecow/maui
that referenced
this pull request
May 22, 2023
* Adjust index path for cell reuseid in carouselview Since CarouselView uses a fake number of items for looping effect like android does, we also need to correct the index used in the base items controller to be the actual item index, not the looped one. * Fix return * Remove ifdef for net8, we are net8 This was also masking the public api txt warnings, but have added the unshipped api's as well.
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Adjust index path for cell reuseid in carouselview Since CarouselView uses a fake number of items for looping effect like android does, we also need to correct the index used in the base items controller to be the actual item index, not the looped one. * Fix return * Remove ifdef for net8, we are net8 This was also masking the public api txt warnings, but have added the unshipped api's as well.
samhouts
added
area-controls-collectionview
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CarouselView uses a fake number of items for looping effect like android does, we also need to correct the index used in the base items controller to be the actual item index, not the looped one.
This fixes the change missed in #12011