Fix issue with CollectionView ignoring margins for content #15246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Eilon
added
the
area-controls-collectionview
|
/rebase |
github-actions
bot
force-pushed
the
fix-collectionview-margins
branch
from
e80ae07
to
654c86b
Compare
rmarinho
approved these changes
May 28, 2023
rmarinho
added
the
backport/suggested
hartez
added
the
backport/NO
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#15114 introduced a bug with CollectionView's content where margins were ignored and the content was positioned at X = 0. These changes fix that situation and add a test to prevent it in the future.