[CI] Remove the template explosion in the CI via a matrix #15334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates are being abused and is resulting in a tempalte explosion, this means that when the templates get expanded we have 100 thousans of lines generated. Azure devops has a limit in the size of the expanded template, and once that limit is reached, the pipeline wont be able to execute. This changes makes the problem go away since a matrix is a native object for azure pipelines and does not get expanded. This PR only takes care of the android emulator tests. A similar PR can be found in the xamarin-macios project: xamarin/xamarin-macios#18312
Eilon
added
the
area-infrastructure
dalexsoto
approved these changes
May 30, 2023
mjbond-msft
reviewed
May 30, 2023
| ${{ replace(coalesce(project.desc, project.name), ' ', '_') }}_API_${{ api }}: | ||
| ${{ if ge(api, 24) }}: | ||
| ANDROID_EMULATORS: "system-images;android-${{ api }};google_apis_playstore;x86" | ||
| ${{ if lt(api, 24) }}: |
There was a problem hiding this comment.
You could probably also use ${{ else }} here instead
There was a problem hiding this comment.
Agreed, but I tried to keep it as close as the original, will do in a second PR.
mjbond-msft
approved these changes
May 30, 2023
rmarinho
approved these changes
May 30, 2023
mandel-macaque
added a commit
that referenced
this pull request
May 30, 2023
This PR is a continuation of #15334 the removes the exact same problem but with the iOS device tests rather than with the android tests. Uses the exact same approach, moves from using a template explosion to a matrix with the diff combinations.
rmarinho
pushed a commit
that referenced
this pull request
May 31, 2023
* [CI] Remove the template explosion in the CI via a matrix This PR is a continuation of #15334 the removes the exact same problem but with the iOS device tests rather than with the android tests. Uses the exact same approach, moves from using a template explosion to a matrix with the diff combinations. * Lower case looks much better.
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates are being abused and is resulting in a template explosion, this means that when the templates get expanded we have 100 thousans of lines generated. Azure devops has a limit in the size of the expanded template, and once that limit is reached, the pipeline wont be able to execute.
This changes makes the problem go away since a matrix is a native object for azure pipelines and does not get expanded.
This PR only takes care of the android emulator tests. A similar PR can be found in the xamarin-macios project:
xamarin/xamarin-macios#18312
For a better idea of what we achieve, the following is the expanded template: https://gist.github.com/mandel-macaque/dda3cda899e975814e563d6e34b50192
The following is the matrix expanded version: https://gist.github.com/mandel-macaque/ddbd66bbfb09531e866ee5b9354b8604
As you can see we go from 18850 yaml lines to 8210, that is over 10000 lines less. This reduces the time it takes for the pipeline to start as well as the effort to debug it.