Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netstandard2.1 #15355

Closed
wants to merge 1 commit into from
Closed

Remove netstandard2.1 #15355

wants to merge 1 commit into from

Conversation

rmarinho
Copy link
Member

Description of Change

netstandard2.1 doesn't. really have a sense in the ".net" world anymore. If one needs it can use netstandard2.0 that will cover all cases.

We are also seeing some errors sometimes building this tfm on Graphics

@rmarinho
Copy link
Member Author

Do we still use this for the IDE?

@mattleibow
Copy link
Member

@drasticactions I recall you when I think about this...

#if !NETSTANDARD2_0
/// <summary>
/// Gets the current IPlatformApplication.
/// This must be set in each implementation manually, as we can't
/// have a true static be used in the implementation.
/// </summary>
public static IPlatformApplication? Current { get; set; }
#endif

@drasticactions
Copy link
Contributor

@drasticactions I recall you when I think about this...

#if !NETSTANDARD2_0
/// <summary>
/// Gets the current IPlatformApplication.
/// This must be set in each implementation manually, as we can't
/// have a true static be used in the implementation.
/// </summary>
public static IPlatformApplication? Current { get; set; }
#endif

I put this in to get access to the current IPlatformApplication without needing Maui.Controls. It was originally for Comet, so we could set the default Application for the Xaml Hot Reload agent so it wouldn't explode when the agents were injected into a Comet/MAUI app, and so later we could expand it on it to enable the XAML Hot Reload tooling (LVT, LPE, etc) to work.

Our Hot Reload agents only work with .NETStandard 2.0, but the public static interface stuff only works on .NETStandard 2.1+. We reflect in our code to get access to this value. So long as that code stays the same, it should still work.

@Eilon Eilon added the area-architecture Issues with code structure, SDK structure, implementation details label Jun 8, 2023
@rmarinho rmarinho closed this Jun 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-architecture Issues with code structure, SDK structure, implementation details do-not-merge Don't merge this PR t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants