[iOS/Catalyst] Fix issue loading images from Stream #16162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
jsuarezruiz
commented
Jul 14, 2023
MartyIX
reviewed
Jul 18, 2023
| { | ||
| await InvokeOnMainThreadAsync(async () => | ||
| { | ||
| var image = ImageSource.FromStream(() => new MemoryStream(Convert.FromBase64String(coffeeBase64))); |
There was a problem hiding this comment.
Should the MemoryStream be disposed? Oh, it might be the responsibility of ImageSource. Hm, IDK :)
mattleibow
reviewed
Jul 26, 2023
jfversluis
approved these changes
Aug 16, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Fix the issue * More changes * Added device test
|
@Eilon, any chance of a backport to .net7? |
|
@UkeHa I'm tagging @rmarinho and @jfversluis who can consider that. |
mattleibow
added
backport/suggested
|
/backport to net7.0 |
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6026855943 |
|
@mattleibow backporting to net7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix the issue
.git/rebase-apply/patch:75: trailing whitespace.
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M src/Core/src/Handlers/Image/ImageHandler.iOS.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Core/src/Handlers/Image/ImageHandler.iOS.cs
CONFLICT (content): Merge conflict in src/Core/src/Handlers/Image/ImageHandler.iOS.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix the issue
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mattleibow an error occurred while backporting to net7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
PureWeen
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Fix the issue * More changes * Added device test # Conflicts: # src/Core/src/Handlers/Image/ImageHandler.iOS.cs
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue loading images from Stream at runtime on iOS.
Issues Fixed
Fixes #12020