Add GetPosition method to DragStartingEventArgs, DragEventArgs, and DropEventArgs #16335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/windows 🪟
platform/android 🤖
platform/iOS 🍎
area-gestures
mandel-macaque
requested changes
Jul 28, 2023
davidbritch
requested changes
Jul 28, 2023
jknaudt21
reviewed
Jul 28, 2023
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs
Outdated
Show resolved
Hide resolved
mandel-macaque
previously approved these changes
Jul 28, 2023
jknaudt21
changed the title
PureWeen
reviewed
Aug 25, 2023
PureWeen
reviewed
Aug 25, 2023
It wasn't doing anything
PureWeen
requested changes
Aug 28, 2023
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs
Outdated
Show resolved
Hide resolved
| @@ -200,7 +198,7 @@ void HandleDrop(object sender, Microsoft.UI.Xaml.DragEventArgs e) | |||
| element = ve; | |||
| } | |||
|
|
|||
| var args = new DropEventArgs(datapackage?.View); | |||
| var args = new DropEventArgs(datapackage?.View!, (relativeTo) => GetPosition(relativeTo, e)); | |||
There was a problem hiding this comment.
if the data package?.View is null maybe we just exit early so we can avoid the null forgiveness operator?
PureWeen
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
GetPosition(IElement relativeTo)method to DragStartingEventArgs, DragEventArgs, and DropEventArgs. This method allows users to get the position of when the drag started and where it currently is relative to a specified element. If the specified element is null, then we get the position relative to the screen.This is similar to the behavior of TappedEventArgs.
All three platforms had native implementations for this functionality.
UI.Xaml.DragEventArgsandUI.Xaml.DragStartingEventArgscan get X and Y positionsMotionEventcan natively get X and YLocationInViewfrom aIUIDragSessionThere are also changes to the Controls.Sample app to show how drag and drop can send locations. The demos were recorded using the sample app.
Demos
Windows
Android
iOS
Screen.Recording.2023-08-16.at.4.40.26.PM.mov
Tests added
Added a 3 UI tests that ensure that the EventArgs are sending the correct location. These tests piggy back from the already existing test scaffolding for DragAndDrop. I cannot test to pixel perfect locations because it varies per platform, but I added a fair amount of checks as to where the relative location should be.
Issues Fixed
Fixes #2793
Remaining work