Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] fix SelectedIndex propagation for picker #16387

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[C] fix SelectedIndex propagation for picker #16387

merged 2 commits into from
Jul 28, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jul 27, 2023 •
edited
Loading

Description of Change

Change picker to use FromHandler vs FromBinding

@StephaneDelcroix StephaneDelcroix changed the title Add test for picker bug [C] fix SelectedIndex propagation for picker Jul 27, 2023
@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-picker Picker labels Jul 27, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 27, 2023
@jsuarezruiz
Copy link
Contributor

Could these changes fix
#16073
#7138
?

@PureWeen
Copy link
Member Author

PureWeen commented Jul 27, 2023 •
edited
Loading

Could these changes fix #16073 #7138 ?

No, this is only related to Stephanes PR around style changes

@PureWeen
Copy link
Member Author

/backport to release/8.0.1xx-preview7

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/5686100940

@github-actions github-actions bot mentioned this pull request Jul 27, 2023
Merged
@rmarinho rmarinho enabled auto-merge (squash) July 27, 2023 23:52
@rmarinho rmarinho merged commit 665d212 into main Jul 28, 2023
39 checks passed
@rmarinho rmarinho deleted the picker_selectedindex branch July 28, 2023 03:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

Assignees

@StephaneDelcroix StephaneDelcroix

Labels
area-controls-picker Picker fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PureWeen @jsuarezruiz @rmarinho @Eilon @StephaneDelcroix @samhouts