[macOS] Don't force the RID to be x64-only #16678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
previously approved these changes
Aug 10, 2023
mattleibow
force-pushed
the
dev/mac-is-arm-too
branch
from
f4d4a03
to
b1385db
Compare
|
Blazor is still causing issues with a parallel/double build of a RID for an app. |
|
The real fix is here: #16765 |
Eilon
added
the
area-infrastructure
StephaneDelcroix
approved these changes
Aug 16, 2023
|
Maybe better
? |
|
/rebase |
We still need to keep the single RID as the blazor bits have issues
github-actions
bot
force-pushed
the
dev/mac-is-arm-too
branch
from
7088eca
to
f01d3c8
Compare
mattleibow
changed the title
jfversluis
approved these changes
Aug 17, 2023
Eilon
reviewed
Aug 17, 2023
| @@ -9,6 +9,7 @@ | |||
| <NoWarn>$(NoWarn),CA1416</NoWarn> | |||
| <!-- Disable multi-RID builds to workaround a parallel build issue --> | |||
| <RuntimeIdentifier Condition="$(TargetFramework.Contains('-maccatalyst'))">maccatalyst-x64</RuntimeIdentifier> | |||
| <RuntimeIdentifier Condition="$(TargetFramework.Contains('-maccatalyst')) and '$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture)' == 'arm64'">maccatalyst-arm64</RuntimeIdentifier> | |||
There was a problem hiding this comment.
Does it matter that this is checking whether the current machine is ARM64? Why would that matter for what RID to target? I get that it matters if you're going to run it, but it shouldn't affect compilation, no?
There was a problem hiding this comment.
Yeah, we typically build and run on the same machine on CI. The real issue is that Blazor and/or maccatalyst can do multiple rids. So without this people on arm64 can or deploy as it always builds x64.
Redth
approved these changes
Aug 18, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
We still need to keep the single RID as the blazor bits have issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use maccatalyst-arm64 on arm64 and maccatalyst-x64 on x64.