[ios] fix memory leak in Picker #16685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/MauiPicker.cs(21,24): error MA0002: Member 'UIPickerView' could cause memory leaks in an NSObject subclass. Remove the member, store the value as a WeakReference, or add the [UnconditionalSuppressMessage("Memory", "MA0002")] attribute with a justification as to why the member will not leak. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(Picker))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by: * Introduce `MauiPickerProxy` for all event subscriptions. Same pattern as in other PRs. * The `ShouldBeginEditing` event was originally subscribed in `CreatePlatformView()` and never unsubscribed. I moved to be subscribed/unsubscribed the same way as the other events. * Refactored the `CreateAlert()` method to be `DisplayAlert()` instead. This allows the handler to do all the work -- and the `MauiPickerProxy` type can call a method on `PickerHandler` once.
jonathanpeppers
added
platform/iOS 🍎
memory-leak 💦
jfversluis
approved these changes
Aug 15, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
Context: #16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/MauiPicker.cs(21,24): error MA0002: Member 'UIPickerView' could cause memory leaks in an NSObject subclass. Remove the member, store the value as a WeakReference, or add the [UnconditionalSuppressMessage("Memory", "MA0002")] attribute with a justification as to why the member will not leak. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(Picker))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by: * Introduce `MauiPickerProxy` for all event subscriptions. Same pattern as in other PRs. * The `ShouldBeginEditing` event was originally subscribed in `CreatePlatformView()` and never unsubscribed. I moved to be subscribed/unsubscribed the same way as the other events. * Refactored the `CreateAlert()` method to be `DisplayAlert()` instead. This allows the handler to do all the work -- and the `MauiPickerProxy` type can call a method on `PickerHandler` once.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #16346
This addresses the memory leak discovered by:
I could reproduce a leak in
MemoryTests.cs:Solved the problem by:
Introduce
MauiPickerProxyfor all event subscriptions. Same pattern as in other PRs.The
ShouldBeginEditingevent was originally subscribed inCreatePlatformView()and never unsubscribed. I moved to be subscribed/unsubscribed the same way as the other events.Refactored the
CreateAlert()method to beDisplayAlert()instead. This allows the handler to do all the work -- and theMauiPickerProxytype can call a method onPickerHandleronce.