Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IElementHandler #16706

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

DianaSoltani
Copy link
Contributor

Description of Change

This pr adds documentation for IElementHandler.cs

@DianaSoltani DianaSoltani added the area-docs Conceptual docs, API docs, Samples label Aug 11, 2023
@DianaSoltani DianaSoltani self-assigned this Aug 11, 2023
@DianaSoltani DianaSoltani requested a review from a team as a code owner August 11, 2023 18:51
@jknaudt21 jknaudt21 changed the title [DocumentationOnly] Add Documentation for IElementHandler Document IElementHandler Aug 11, 2023
Copy link
Contributor

@jknaudt21 jknaudt21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a couple of slight tweaks.

src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/IElementHandler.cs Show resolved Hide resolved
@samhouts samhouts added this to the .NET 8 GA milestone Aug 15, 2023
@rmarinho rmarinho merged commit 86b71e1 into main Aug 17, 2023
39 checks passed
@rmarinho rmarinho deleted the dev/dianasoltani/addIElementHandlerDocumentation branch August 17, 2023 11:23
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
* Add Documentation for IElementHandler

* apply cr suggestions

---------

Co-authored-by: Diana Soltani <dianasoltani@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants