Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Fix Picker PointerOver TextColor (#16751) #16752

Merged
merged 1 commit into from
Aug 19, 2023
Merged

[windows] Fix Picker PointerOver TextColor (#16751) #16752

merged 1 commit into from
Aug 19, 2023

Conversation

molesmoke
Copy link
Contributor

Description of Change

Add missing resource key to allow PointerOver style to work for Picker controls on Windows

Issues Fixed

Fixes #16751

@jeremy-visionaid
[windows] Fix Picker PointerOver TextColor (dotnet#16751)
9810f67 
Add missing resource key to allow PointerOver styles to work for Picker
controls
@molesmoke molesmoke requested a review from a team as a code owner August 15, 2023 08:50
@ghost ghost added the community ✨ Community Contribution label Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

Hey there @molesmoke! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis jfversluis added platform/windows 🪟 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-picker Picker labels Aug 15, 2023
@PureWeen PureWeen enabled auto-merge (squash) August 15, 2023 10:15
@jfversluis
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@samhouts samhouts added this to the Under Consideration milestone Aug 15, 2023
@rmarinho
Copy link
Member

/azp run MAUI-DeviceTests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen merged commit 9cec15b into dotnet:main Aug 19, 2023
37 of 39 checks passed
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
@molesmoke @jeremy-visionaid @rmarinho
[windows] Fix Picker PointerOver TextColor (#16751) (#16752)
41b5233 
Add missing resource key to allow PointerOver styles to work for Picker
controls

Co-authored-by: Jeremy Powell <jeremy@visionaid.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts removed this from the Under Consideration milestone Jul 1, 2024
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@jfversluis jfversluis jfversluis approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-picker Picker community ✨ Community Contribution fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Picker TextColor on PointerOver has no effect
8 participants
@molesmoke @jfversluis @rmarinho @mattleibow @Eilon @PureWeen @samhouts @jeremy-visionaid