Fix Flyout Crash (Windows) #16800
Merged
Fix Flyout Crash (Windows) #16800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foda
added
platform/windows 🪟
area-controls-flyout
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
added
the
legacy-area-controls
PureWeen
requested changes
Aug 18, 2023
There was a problem hiding this comment.
I think we also need to change all
RemoveLogicalChild(element, index); to RemoveLogicalChild(element)
I don't think we have a guarantee that this index will match up with the index of the logical child since this might have other logical children.
If it's not too much work it would be cool to give
public abstract partial class Layout<T> The same treatment.
I'd like to just get rid of everywhere that we're using
private protected override IList<Element> LogicalChildrenInternalBackingStore
=> InternalChildren;
|
/rebase |
PureWeen
requested changes
Aug 24, 2023
PureWeen
approved these changes
Aug 25, 2023
rmarinho
added a commit
that referenced
this pull request
Aug 29, 2023
* [Android] Fix Keyboard.Numeric issue (#16163) * Fix Keyboard.Numeric issue on DisplayPromptAsync on Android * Remove AlertsPage sample --------- Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> * Invalidate shell tab title on Windows (#16593) Co-authored-by: Rui Marinho <me@ruimarinho.net> * Fix Flyout Crash (Windows) (#16800) * Fix flyout crash due to invalid casting of child * Add tests * Add additional tests, PR feedback * Fix missing call to `RemoveLogicalChild` * Update Clear --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> * [core] factory methods for registering services, part 2 (#17004) b0bba51 was incomplete, in that it missed registrations with 1 type argument: builder.Services.AddScoped<HideSoftInputOnTappedChangedManager>(); So we need to add entries with "`1" for all of the banned methods: ++M:Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddScoped`1(Microsoft.Extensions.DependencyInjection.IServiceCollection);Use a Factory method to register the service instead M:Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddScoped`2(Microsoft.Extensions.DependencyInjection.IServiceCollection);Use a Factory method to register the service instead We can improve startup time by using a factory method instead: builder.Services.AddScoped(_ => new HideSoftInputOnTappedChangedManager()); This also found a couple more calls to fix throughout .NET MAUI. * [create-pull-request] automated change (#17017) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Ignore failures from newly added UITests temporarily (#17003) * Ignore failures from WhenQueryingCarouselItemsInViewThenSingleItemIsRetrieved * Update Ignore to include all platformss * Center window on WinUI, so it's always fully on screen in CI * Set agent screen resolution bigger for UI tests * Update baseline snapshots for bigger screen * Just set screen resolution on Windows * Ignore Issue16320 on Android * Fix Android text alignment in migrated projects (#16986) * Fix Android text alignment in migrated projects * Add (manual) device tests * Add clarifying comment * [tentative] Move input tests to generic code * Wrap up tests * Make masks constants * Fix title to be consistent with other test names * Fix the order of logical modifications (#17020) * Fix the order of logical modifications * - keep in sync while removing * - fix clear --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> Co-authored-by: Mike Corsaro <corsarom@gmail.com> Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bret Johnson <bret.johnson@microsoft.com> Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes flyouts on custom controls created in constructors. Most of it was done w/ assistance and guidance from @PureWeen -- hence the additional modifications to
OnAdd, etc.Additionally, some add + remove item tests have been added for Context Menu/Flyout on Windows.
Issues Fixed
Fixes #16663