Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Handler Events to Changing/Changed #1692

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Conversation

PureWeen
Copy link
Member

Description of Change

Attaching/Attached/Detaching/Detached are difficult to interpret when a Handler is changed to a new handler. Using a "Changing" approach that has the Old and New handler on it provides a more useful context for action.

For Changed we are still just using EventArgs because at the point that you've hit changed it's not recommended to access the previous handler. So if users want to access the old handler it's on them to do so and understand the risks

Additions made

  • Adds Microsoft.Maui.Controls.HandlerChangingEventArgs
  • Adds HandlerChanging
  • Adds HandlerChanged
  • Removes Attaching/Attached/Detaching/Detached

@PureWeen PureWeen requested a review from hartez July 15, 2021 20:19
@Redth Redth added this to the 6.0.100-preview.7 milestone Jul 16, 2021
@mattleibow mattleibow merged commit 271b5ad into main Jul 20, 2021
@mattleibow mattleibow deleted the handler_lc_fixes branch July 20, 2021 19:55
@samhouts samhouts added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants