Convert Handler Events to Changing/Changed #1692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Attaching/Attached/Detaching/Detached are difficult to interpret when a Handler is changed to a new handler. Using a "Changing" approach that has the Old and New handler on it provides a more useful context for action.
For Changed we are still just using EventArgs because at the point that you've hit changed it's not recommended to access the previous handler. So if users want to access the old handler it's on them to do so and understand the risks
Additions made
Microsoft.Maui.Controls.HandlerChangingEventArgs