[workload] Move default item updates to workload sdk #16990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#16501 Context: dotnet@95913ed Context: dotnet@2dcc148 Attempts to improve xaml.cs file nesting by moving xaml.cs item updates back into the workload SDK. Some of this logic was moved out of `Microsoft.Maui.Sdk.After.targets` in commit 95913ed, and subsequently moved out of the workload and into a NuGet package in commit 2dcc148. I believe it should be harmless to move these default item properties and the Compile / None item updates back into the workload SDK to avoid solution explorer display issues on first run.
pjcollins
requested review from
jfversluis,
PureWeen,
jonathanpeppers and
mattleibow
mattleibow
approved these changes
Aug 25, 2023
|
How can I test this? |
|
This will require installing the workload but not installing the rest of the nugets. Basically, testing the project puts the cs under the Xaml even when the nugets are unavailable. |
jonathanpeppers
approved these changes
Aug 25, 2023
mattleibow
added a commit
that referenced
this pull request
Aug 29, 2023
This reverts commit d85704d.
mattleibow
added a commit
that referenced
this pull request
Aug 29, 2023
This reverts commit d85704d.
This was referenced Aug 30, 2023
mattleibow
added a commit
that referenced
this pull request
Oct 6, 2023
This reverts commit d85704d.
mattleibow
added a commit
that referenced
this pull request
Oct 6, 2023
This reverts commit d85704d.
This was referenced Oct 6, 2023
mattleibow
added a commit
that referenced
this pull request
Oct 9, 2023
This reverts commit d85704d.
mattleibow
added a commit
that referenced
this pull request
Oct 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit d85704d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16501
Context: 95913ed
Context: 2dcc148
Attempts to improve xaml.cs file nesting by moving xaml.cs item updates
back into the workload SDK. Some of this logic was moved out of
Microsoft.Maui.Sdk.After.targetsin commit 95913ed, and subsequentlymoved out of the workload and into a NuGet package in commit 2dcc148.
I believe it should be harmless to move these default item properties
and the Compile / None item updates back into the workload SDK to avoid
solution explorer display issues on first run.