Fix TabbedPage title displaying incorrectly #17039

Adam-- · 2023-08-28T18:39:37Z

Description of Change

Presently, when a navigation page is created and a tabbed page is added to it with children, the navigation page uses the tabbed page's selected child title as its title. This behavior is unexpected when using standard tabs (tabs on the top) in a navigation page on Android.

Without a custom tabbed page, this behavior makes sense, especially for bottom tabs; however, when a custom tabbed page is defined, it seems that the title should not be overridden.

NavigationPageToolbar now checks if its current page is a TabbedPage and it has a title set and if so, it'll use that Title instead. Style matches GetTitleView for consistency.

Edit:
During the review of this PR, we noticed the inconsistency that occurred between iOS and Android that when the title was not specified for the TabbedPage, on Android platforms, it would use the Child title. When replicated in Xamarin Forms, the behavior was consistent, in that the child page title was NOT used on either platform. So to assist in ading migration to Xamarin Forms, in addition to fixing titles in TabbedPage, this PR will also make the behavior consistent between platforms and have child page titles NOT be used when TabbedPage titles are empty or null.

Issues Fixed

Fixes #8577

Presently, when a navigation page is created and a tabbed page is added to it with children, the navigation page uses the tabbed page's selected child title as its title. This behavior is unexpected when using standard tabs (tabs on the top) in a navigation page on Android. Without a custom tabbed page, this behavior makes sense, especially for bottom tabs; however, when a custom tabbed page is defined, it seems that the title should not be overridden. Fixes dotnet#8577

ghost · 2023-08-28T18:39:45Z

Hey there @Adam--! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Adam-- · 2023-08-28T18:58:32Z

I'd like some help with unit tests if possible. I attempted to add unit tests in \src\Controls\tests\Core.UnitTests\ToolbarTests.cs; however, I'm finding that in the unit tests NavigationPageToolbar OnPageAppearing doesn't get called for the TabbedPage's children and ultimately the tests fail with the toolbar title being null. When I run on a device (Android and Windows) this gets called and the title is as expected. Is there something I'm missing in the unit tests?

jfversluis · 2023-08-29T11:46:36Z

/azp run

azure-pipelines · 2023-08-29T11:46:53Z

Azure Pipelines successfully started running 2 pipeline(s).

jsuarezruiz · 2023-09-29T11:35:51Z

/azp run

azure-pipelines · 2023-09-29T11:36:11Z

Azure Pipelines successfully started running 3 pipeline(s).

Adam-- · 2023-09-29T12:56:38Z

@jsuarezruiz these tests fail due to the reason I mentioned last month. Would you be able to help out with them? If it's simply not possible to unit test, I can remove them. The bug that this fixes is very silly and I'd really like to get it fixed.

PureWeen · 2024-02-16T22:20:35Z

/rebase

PureWeen

Can you rebase against main?

I know it's been forever.

Let me know if you want me to take this one over or not.
We have the issue in our current iteration, so it doesn't get lost again.

src/Controls/tests/Core.UnitTests/ToolbarTests.cs

PureWeen · 2024-02-16T22:47:32Z

src/Controls/src/Core/NavigationPage/NavigationPageToolbar.cs

+
+			Page target = _currentPage;
+
+			if (_currentNavigationPage?.CurrentPage is TabbedPage tabbedPage && !string.IsNullOrEmpty(tabbedPage.Title))


I wonder if this needs to check the page type at all.

I'm testing a few variations of pages on Xamarin.Forms, and the Title always seems to just be whatever the current page is on the navigation page.

Is there ever a scenario where
_currentNavigationPage.CurrentPage.Title isn't what we want here?

I think _currentNavigationPage.CurrentPage.Title should be the correct value in all scenarios.

PureWeen · 2024-02-16T22:51:56Z

src/Controls/tests/DeviceTests/Elements/Toolbar/ToolbarTests.cs

@@ -117,6 +117,43 @@ public async Task ToolbarTitle()
 			});
 		}

+		[Fact(DisplayName = "Toolbar Uses TabbedPage Title When Set")]
+		public async Task ToolbarTabbedPageTitle()


I think it's alright to remove these. We have tests that validate that Toolbar.Title makes it to the platform. So, I think the unit tests plus those tests cover what we need.

Ok, removed and added more tests validating the title changing tabs etc.

PureWeen · 2024-02-21T21:17:21Z

/azp run

azure-pipelines · 2024-02-21T21:17:44Z

Azure Pipelines successfully started running 3 pipeline(s).

Adam-- · 2024-02-22T19:55:37Z

@PureWeen @jsuarezruiz Thanks for getting back to me on this and tackling the tests, I appreciate it.

jsuarezruiz · 2024-03-27T12:43:35Z

/azp run

azure-pipelines · 2024-03-27T12:43:54Z

Azure Pipelines successfully started running 3 pipeline(s).

dustin-wojciechowski · 2024-04-13T04:32:34Z

The test that is failing, ToolbarTabbedPageChildTitle() is failing for ios. I believe the expected behavior is that when a title is not specified for the toolbar, the child page's title will appear as the toolbar title instead.

Android (Correct)

IOS (Incorrect)

Investigating why this could be.

…title

dustin-wojciechowski · 2024-04-22T19:30:27Z

Testing with Xamarin Forms, the Child Page title did not replace the title in the Toolbar if a title was not specified for the toolbar for either platform.

To keep things consistent between frameworks, that behavior will be kept intact while also ensuring that the title is properly set in MAUI.

dustin-wojciechowski · 2024-04-23T20:03:41Z

/azp run

azure-pipelines · 2024-04-23T20:04:01Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-04-28T22:13:42Z

/rebase

PureWeen · 2024-04-28T22:14:44Z

/azp run

azure-pipelines · 2024-04-28T22:15:05Z

Azure Pipelines successfully started running 3 pipeline(s).

@LeDahu22

* [iOS] Fix crash closing Popup with WebView (#21718) * Added repro sample * Fix the issue * Added UI Test * Updated csproj * More changes * Removed sample and test * More changes * Removed unnecesary changes * Update dependencies from https://github.com/dotnet/xharness build 20240408.1 (#21839) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.24203.1 -> To Version 9.0.0-prerelease.24208.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [Android] Fix crash navigating back (#20420) * Fix the issue * Added device test * [XC] Fix x:DataType resolution for BindingContext (#21454) * Add test * Add special case for resolving x:DataType for the binding context property * [X] Fix TargetType simplification bug (#21764) * Add unit test * Simplify TargetType=x:Type before setting resources * fix: Use AppContext.BaseDirectory instead of Environment.CurrentDirectory (#21797) #21750 --------- Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com> * Remove 2nd webview2 used to add `base` tag to passed html * Revert script to OG version * [ios/catalyst] fix memory leak with CollectionView (#21850) Fixes: #20710 Context: https://github.com/marco-skizza/MauiCollectionView Testing the sample above, you can see a memory leak when setting up a `CollectionView`'s `DataTemplate` in XAML, but it appears to work just fine with C#. Using `dotnet-gcdump` with a `Release` build of the app, I see: ![image](https://github.com/dotnet/maui/assets/840039/6b4b8682-2989-4108-8726-daf46da146e4) You can cause the C# version to leak, if you make the lambda an instance method: * jonathanpeppers/iOSMauiCollectionView@3e5fb02 XAML just *happens* to use an instance method, no matter if XamlC is on/off. I was able to reproduce this in `CollectionViewTests.iOS.cs` by making the `CollectionView` look like a "user control" and create an instance method. There is a "cycle" that causes the problem here: * `Microsoft.Maui.Controls.Handlers.Items.VerticalCell` (note this is a `UICollectionViewCell`) -> * `DataTemplate` -> * `Func<object>` -> * `PageXamlLeak` (or `PageCsOk` w/ my change) -> * `CollectionView` -> * `Microsoft.Maui.Controls.Handlers.Items.VerticalCell` The solution being to make `TemplatedCell` (which is a subclass of `VerticalCell`) hold only a `WeakReference` to the `DataTemplate`. With this change in place, the test passes. ~~ Notes about Catalyst ~~ 1. The new test passes on Catalyst (with the `#if` removed), if you run it by itself 2. If you run *all* the tests, it seems like there is a `Window` -> `Page` -> `CollectionView` that makes the test fail. 3. This seems like it's all related to the test setup, and not a bug. It seems like what is here might be OK for now? If Catalyst leaks, it would probably leak on iOS as well and the test passes there. * [tests] add `SourceGen.UnitTests` to CI (#21889) Context: #21725 In #21725 we noticed the source generator unit tests (for `*.xaml.g.cs`) don't run on CI. Whoops! * [C] Propagate resources when reparenting (#21879) * [C] Propagate resources when reparenting - fixes a bug when the theme is changed while the control/page isn't parented. Should fix @LeDahu22 reported issue of #21744 * move logic to resourcesextensions * [iOS] Fix crash closing Popup with WebView (#21923) * [iOS] Fix crash closing Popup with WebView (#21718) * Added repro sample * Fix the issue * Added UI Test * Updated csproj * More changes * Removed sample and test * More changes * Removed unnecesary changes * Added UITest * Update Issue21846.xaml.cs * Update Issue21846Modal.xaml.cs * Update Issue21846.cs --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> * Update locker.yml (#21894) * Bump the Locker action version Refer to microsoft/vscode-github-triage-actions#210 * Restrict the Locker action to dotnet org * do not scroll if the view is in the navbar (#21806) * [windows] less interops in calling `get_Children` (#21792) The PR trivially attempts to decrease the number of interops, using a local variable. Contributes to #21787 * [controls] fix leak in ImageSource, caused by Task that never completes (#21928) Context: https://github.com/AdamEssenmacher/MemoryToolkit.Maui/tree/main/samples Testing the above sample, I saw some odd results in a `.gcdump` related to `UriImageSource` inside a `CollectionView`: AsyncTaskMethodBuilder+AsyncStateMachineBox<VoidTaskResult, Microsoft.Maui.Controls.ImageElement+<CancelOldValue>d__10>, Count: 182 Dictionary+Entry<Int32, Task>[], Count: 182 Dictionary<Int32, Task> [Static variable Task.s_currentActiveTasks], Count: 1 It appears that we `await` a `Task` that never completes, which is: https://github.com/dotnet/maui/blob/8e4450cbc14932a6c74aeb8b7bfee9c94eca18b0/src/Controls/src/Core/ImageElement.cs#L129 The `Task` also holds onto the `ImageSource` and whatever memory it happened to use. That would be ok if the `Task` completed. I could reproduce the problem in a test: [Fact] public async Task CancelCompletes() { var imageSource = new StreamImageSource { Stream = _ => Task.FromResult<Stream>(new MemoryStream()) }; await ((IStreamImageSource)imageSource).GetStreamAsync(); await imageSource.Cancel(); // This should complete! } This non-completing `Task` can occur when changing `Image.Source`, which would certainly be bad while scrolling a `CollectionView`! To fix, I refactored the code slightly and had the problematic case return: return Task.FromResult(false); * More IndexOf() optimization (#20083) * Use better IndexOf where possible * apply similar performance improvement to the predicate-based IndexOf() * use built-in IndexOfChild on Android * add braces as per new editorconfig rule * use TryGetValue to avoid double lookup --------- Co-authored-by: Edward Miller <symbiogenisis@outlook.com> * Go back to ignoring ExpectingPageNotToBreak (#21940) * [ios/catalyst] fix memory leak in gestures (#21887) * [ios/catalyst] fix memory leak in gestures Related: #21089 Context: jonathanpeppers/iOSMauiCollectionView@547b7fa Doing something like this and running on iOS or Catalyst: <CollectionView.ItemTemplate> <DataTemplate> <Label Text="{Binding Name}"> <Label.GestureRecognizers> <TapGestureRecognizer Command="{Binding BindingContext.Command}" /> </Label.GestureRecognizers> </Label> </DataTemplate> </CollectionView.ItemTemplate> Causes a memory leak. I could reproduce this in a test that is a bit more elaborate than #21089, showing issues for different types of gestures: * Usage of `ShouldReceiveTouch` creates a cycle: * `GesturePlatformManager` -> `UIGestureRecognizer.ShouldReceiveTouch` -> `GesturePlatformManager` * We can move `ShouldReceiveTouch` to a "proxy" class, and avoid the cycle. * `PanGestureRecognizer` has closures that cause the same cycle: * `this.PlatformView` -> `eventTracker?.PlatformView` * `panRecognizer` -> `((PanGestureRecognizer)panGestureRecognizer)` * These already had a `WeakReference` to use instead, but we could just make use of them. There *may* be a general problem with `CollectionView` in how it doesn't tear down `GesturePlatformManager` in the same way for children. But in either case, the problems above are cycles that should be broken. * Fix test on Windows * Setup scaffolding for legacy test runner (#21423) * Just added a couple of tests * Focus on Android and iOS (for now) * Added legacy tests to the pipeline * More changes * More changes * Fixed build * Created ui-tests-legacy-steps.yml * More changes * More changes * Updated Appium to RC7 * Update ui-tests.yml * Fixed test on Android * Fixed test * More changes * More changes * Updated snapshot * More fixes * Clean code * Run test only on iOS * Added pending constant * Fix build error * More changes * Update ControlGallery.iOS.Appium.UITests.csproj * Update ControlGallery.Shared.Appium.UITests.csproj * Trying to run only on iOS * This is the fix, I feel it * Fix merge error --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * [WinUI] `GesturePlatformManager.Windows.cs` - unused variable (#21953) * Code style * Remove unused line * IndexOf() stackOverflow fix (#20083) (#21965) * Update EnumerableExtensions.cs * Update EnumerableExtensions.cs * Add visual test for webview2 on windows * add EnumerableTests (#21978) Co-authored-by: Edward Miller <symbiogenisis@outlook.com> * Re-generate template localization (#21988) * Add s/triaged label for issues opened by (core) team (#22006) * Add s/triaged label for issues opened by (core) team Alternate approach to #21775 as that clearly didn't work. Hoping this _will_ work! From the original PR: > Adds a rule to the bot that adds the s/triaged label to an issue which is opened by the core team (someone with write permissions on the repo). A lot of times these issues are tasks and/or very cryptic to the triage team. This way, the triage team will skip these issues and we assume the issues are valid ones and/or not issues that need triage. * Update resourceManagement.yml * Add latest .NET9 and .NET8 (#22034) * [iOS] Add UITest for #21806 (#21951) * Add UITest and use IsDescendant of ContainverVC * Add button to focus entry in the navbar * UITests working separately * Use the modal stack * [ios/catalyst] fix memory leaks in ListView (#22007) * [ios/catalyst] fix memory leaks in ListView Fixes: #20025 I could reproduce the leak here, pretty easily with changes to `MemoryTests`. `ListView` has several cycles that prevent garbage collection from happening: * `FormsUITableViewController` has `ListView _list` * `FormsUITableViewController` -> `ListView` -> `ListViewRenderer` -> `FormsUITableViewController` * `ListViewDataSource` has `UITableView _uiTableView` * `ListViewDataSource` -> `UITableView` -> `ListViewDataSource` * `ListViewDataSource` has `FormsUITableViewController _uiTableViewController` * `ListViewDataSource` -> `FormsUITableViewController` -> `UITableView` -> `ListViewDataSource` * `ListViewDataSource` has `protected ListView List` * `ListViewDataSource` -> `ListView` -> `ListViewRenderer` -> `FormsUITableViewController` -> `UITableView` -> `ListViewDataSource` I changed the above fields to all be `WeakReference<T>` and the leaks went away. * Tentative fix for Android Context: #18757 * Revert "Tentative fix for Android" This reverts commit b294779. * Ignore ListView test on Android for now * [UI Testing] Split mouse and touch Appium actions and added pending ones (TouchAndHold etc) (#21305) * Split mouse and touch Appium actions * More changes * Fixes * Fix build errors * More changes * Fix build errors * More updates * [Windows] Use correct build version check (#22013) * [Windows] Use correct build version check Windows 11 version isn't actually 11.*, it's 10.0.21996 * Update Connectivity.uwp.cs * Navigate Directly to Test (#22019) * Navigate Directly To Test * - add additional wait for element * Fix main (#22065) Remove duplicate Tap method * [iOS] Implemented PrefersHomeIndicatorAutoHidden, PrefersStatusBarHidden and PreferredStatusBarUpdateAnimation Platform Specifics (#20069) * iOS page specifics * Added a sample (#19970) * Code refactor * Replaced public with internal --------- Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com> * Reenabled ReturnsNonEmptyNativeBoundingBox tests on Windows (#20238) * [iOS] Allow compat iOS buttons to resize image and to respect spacing and padding (#21759) * Fix the iOS button to resize the image, respect padding, and respect spacing * allow UITest - waiting for CI results * Allow the image to actually take up the whole space and fix issue with buttons without images or titles resizing * Add UITest screenshot * remove changes to sandbox * Added manual testing sample * More changes in the sample * Do not hide the text if it doesn't fit and resize if no title * UITests cannot share the same name --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> * Fix null reference exception in KeyboardAutoManagerScroll when UIWindow is null (#21753) * Fix null reference when window is null When using certain controls ie bottom sheets and search bars there can be a crash when the keyboard displays. Check for null & return early if it is. * set flag to false if returning * remove change on line 1 * Add IsDescendant of ContainerVC * remove the extra IsKeyboardAutoScrollHandling flag * remove extra style changes * Add UITest * Use UIView AccessibilityIdentifier on UITest * Add ignore in platform and remove catch in favor of rebasing main --------- Co-authored-by: tj-devel709 <tj.devel709@gmail.com> * Fix screenshot for 18242 for new test behavior (#22081) * [android] use Java primitive `boolean` for `UriImageSource` (#22040) Context: https://cs.android.com/android/platform/superproject/main/+/main:libcore/ojluni/annotations/hiddenapi/java/lang/Boolean.java;l=109?q=boolean.java Some internal APIs in MAUI were using `java.lang.Boolean` when they could just use `boolean` instead. Java `boolean` is a primitive type, while `java.lang.Boolean` is an object (that can be null). This is similar to `bool` vs `bool?` in C#, except Java does not have `struct`. This avoids: * JNI field lookup of `Boolean.TRUE` and `Boolean.FALSE` on startup * JNI field reads of `Boolean.TRUE` and `Boolean.FALSE` on every `UriImageSource` creation * Creating a C# instance of `Java.Lang.Boolean`, and the bookkeeping for reusing C# instances I was also going to change `ImageLoaderCallback.onComplete`, but it is listed as a public API. This is a small improvement, but should help all `UriImageSource` on Android. * Fix (#22033) * fix CA1864 (#22092) Co-authored-by: Edward Miller <symbiogenisis@outlook.com> * Improve error logging for failed resizetizering (#22064) * Improve error logging for failed resizetizering * Fix tests * [UI Testing] Implement PressEnter method (#22112) * Implement PressEnter method on appium * IsKeyboardShown not implemented on Windows * Updated test * Fix TabbedPage title displaying incorrectly (#17039) * Fix TabbedPage title displaying incorrectly Presently, when a navigation page is created and a tabbed page is added to it with children, the navigation page uses the tabbed page's selected child title as its title. This behavior is unexpected when using standard tabs (tabs on the top) in a navigation page on Android. Without a custom tabbed page, this behavior makes sense, especially for bottom tabs; however, when a custom tabbed page is defined, it seems that the title should not be overridden. Fixes #8577 * Add device tests * Add unit tests * Updated test * More tests * Fixed test not being able to fail * Changed GetTitle to work with more than just TabbedPages * Removed tests that deal with Child page titles replacing the Toolbar title --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Dustin Wojciechowski <dustin.wojciechowski@microsoft.com> Co-authored-by: Dustin Wojciechowski <dustinwo@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20240424.1 (#22119) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.24208.1 -> To Version 9.0.0-prerelease.24224.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [Android] Crash removing item from CarouselView - fix (#22107) * Fix #19786 * Added a Ui test (#19786) * Update MauiCarouselRecyclerView.cs * [iOS] Shell page title fix (#20575) * [iOS] Shell page title fix (#20199) * Added a UiTest (#20199) * Added pending snapshot * Shell page title fix --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> * Add VS Code Extension to move-to-vs-feedback label (#22152) * Android mipmap/appicon failing with "APT2260" (#21838) Context https://developercommunity.visualstudio.com/t/Android-mipmapappicon-failing-with-APT/10622494 Users are reporting this error quite allot. During a build it fails with the following error ``` APT2260 resource mipmap/appicon (aka xxx:mipmap/appicon) not found. ``` Further investigation this only appears to happen during a full build of all the platforms. Specifying `-f net8.0-android` on the build this does not seem to happen at all. The problem is the build gets into a weird situation where the `mauiimage.stamp` file is present but none of the generated images are. Considering that the stamp file gets generated AFTER the images its kinda difficult to see how this even occurs. The work around for this is to write the list of generated image files to `mauiimage.outputs`. We can then read this list back on subsequent builds and use that list for the `Outputs` of the `ResizetizeImages` target. This means the target will run if either the stamp file or any of the expected images are not present. * Create similarIssues.yml (#22170) * Support manual triggering of similar issues (#22176) --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Šimon Rozsíval <simon@rozsival.com> Co-authored-by: Precious Nyasulu <preciousnyasulu441@gmail.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com> Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> Co-authored-by: Edward Miller <symbiogenesis@outlook.com> Co-authored-by: Edward Miller <symbiogenisis@outlook.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Mike Corsaro <corsarom@gmail.com> Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com> Co-authored-by: Axemasta <33064621+Axemasta@users.noreply.github.com> Co-authored-by: tj-devel709 <tj.devel709@gmail.com> Co-authored-by: Adam Anderson <andersad@gmail.com> Co-authored-by: Dustin Wojciechowski <dustinwo@microsoft.com> Co-authored-by: Dean Ellis <dellis1972@googlemail.com> Co-authored-by: Craig Loewen <crloewen@microsoft.com>

Adam-- added 2 commits August 28, 2023 14:32

Add device tests

547da58

Adam-- requested a review from a team as a code owner August 28, 2023 18:39

Adam-- requested review from StephaneDelcroix and rachelkang August 28, 2023 18:39

ghost added the community ✨ Community Contribution label Aug 28, 2023

Add unit tests

b7effe9

PureWeen requested review from PureWeen and removed request for StephaneDelcroix August 28, 2023 19:15

samhouts added this to the Under Consideration milestone Aug 29, 2023

samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 15, 2023

Eilon added the area-controls-tabbedpage TabbedPage label Nov 9, 2023

PureWeen requested changes Feb 16, 2024

View reviewed changes

PureWeen requested review from jsuarezruiz and removed request for rachelkang February 20, 2024 17:30

jsuarezruiz added 3 commits February 21, 2024 10:37

Merge branch 'main' into bugfix-toolbar-tabbedpage-title

413a3a0

Updated test

1fc350b

More tests

0efcfa4

jsuarezruiz previously approved these changes Feb 21, 2024

View reviewed changes

jsuarezruiz requested a review from PureWeen February 21, 2024 10:09

Adam-- mentioned this pull request Mar 22, 2024

TabbedPage title displays incorrectly. It displays current selected child page title #8577

Closed

PureWeen removed this from the Under Consideration milestone Mar 29, 2024

Fixed test not being able to fail

3eed94c

dustin-wojciechowski dismissed jsuarezruiz’s stale review via 3eed94c April 13, 2024 03:59

dustin-wojciechowski added 2 commits April 22, 2024 11:56

Changed GetTitle to work with more than just TabbedPages

091139f

Removed tests that deal with Child page titles replacing the Toolbar …

9f7204b

…title

PureWeen approved these changes Apr 29, 2024

View reviewed changes

PureWeen enabled auto-merge (squash) April 29, 2024 20:59

PureWeen merged commit 6328b76 into dotnet:main Apr 29, 2024
49 checks passed

github-actions bot locked and limited conversation to collaborators May 30, 2024

samhouts added fixed-in-8.0.40 fixed-in-9.0.0-preview.5.24307.10 labels Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TabbedPage title displaying incorrectly #17039

Fix TabbedPage title displaying incorrectly #17039

Adam-- commented Aug 28, 2023 •

edited by dustin-wojciechowski

Loading

ghost commented Aug 28, 2023

Adam-- commented Aug 28, 2023

jfversluis commented Aug 29, 2023

azure-pipelines bot commented Aug 29, 2023

jsuarezruiz commented Sep 29, 2023

azure-pipelines bot commented Sep 29, 2023

Adam-- commented Sep 29, 2023

PureWeen commented Feb 16, 2024

PureWeen left a comment

PureWeen Feb 16, 2024

jsuarezruiz Feb 21, 2024

PureWeen Feb 16, 2024

jsuarezruiz Feb 21, 2024

PureWeen commented Feb 21, 2024

azure-pipelines bot commented Feb 21, 2024

Adam-- commented Feb 22, 2024

jsuarezruiz commented Mar 27, 2024

azure-pipelines bot commented Mar 27, 2024

dustin-wojciechowski commented Apr 13, 2024

dustin-wojciechowski commented Apr 22, 2024

dustin-wojciechowski commented Apr 23, 2024

azure-pipelines bot commented Apr 23, 2024

PureWeen commented Apr 28, 2024

PureWeen commented Apr 28, 2024

azure-pipelines bot commented Apr 28, 2024


		Page target = _currentPage;

		if (_currentNavigationPage?.CurrentPage is TabbedPage tabbedPage && !string.IsNullOrEmpty(tabbedPage.Title))

Fix TabbedPage title displaying incorrectly #17039

Fix TabbedPage title displaying incorrectly #17039

Conversation

Adam-- commented Aug 28, 2023 • edited by dustin-wojciechowski Loading

Description of Change

Issues Fixed

ghost commented Aug 28, 2023

Adam-- commented Aug 28, 2023

jfversluis commented Aug 29, 2023

azure-pipelines bot commented Aug 29, 2023

jsuarezruiz commented Sep 29, 2023

azure-pipelines bot commented Sep 29, 2023

Adam-- commented Sep 29, 2023

PureWeen commented Feb 16, 2024

PureWeen left a comment

Choose a reason for hiding this comment

PureWeen Feb 16, 2024

Choose a reason for hiding this comment

jsuarezruiz Feb 21, 2024

Choose a reason for hiding this comment

PureWeen Feb 16, 2024

Choose a reason for hiding this comment

jsuarezruiz Feb 21, 2024

Choose a reason for hiding this comment

PureWeen commented Feb 21, 2024

azure-pipelines bot commented Feb 21, 2024

Adam-- commented Feb 22, 2024

jsuarezruiz commented Mar 27, 2024

azure-pipelines bot commented Mar 27, 2024

dustin-wojciechowski commented Apr 13, 2024

dustin-wojciechowski commented Apr 22, 2024

dustin-wojciechowski commented Apr 23, 2024

azure-pipelines bot commented Apr 23, 2024

PureWeen commented Apr 28, 2024

PureWeen commented Apr 28, 2024

azure-pipelines bot commented Apr 28, 2024

Adam-- commented Aug 28, 2023 •

edited by dustin-wojciechowski

Loading