Limit star expansion when measuring/arranging at constrained sizes #17880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
area-layout
samhouts
approved these changes
Oct 16, 2023
rmarinho
approved these changes
Oct 16, 2023
Closed
|
/backport to release/8.0.1xx-rc2.2 |
|
Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6632066347 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For constrained measurement, when definition sizes are determined during the measure pass the star sizes are limited by the number of stars which can fit into the constraint. During arrange, if the actual arrange size is different, then the size of a star definition needs to be limited by the number of stars which can fit into the arranged size.
Proposing this as an alternative to #17199 - this is a less extensive change to achieve the same effect.
Issues Fixed
Fixes #17125