-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net6.0 to the projects #1810
Conversation
@@ -63,6 +63,11 @@ | |||
<MonoAndroidAssetsPrefix>$(AndroidProjectFolder)Assets</MonoAndroidAssetsPrefix> | |||
</PropertyGroup> | |||
|
|||
<!-- .NET Standard or .NET 6 --> | |||
<PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'"> | |||
<DefineConstants>$(DefineConstants);NETSTANDARD</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no need to re-define these (https://github.com/dotnet/designs/blob/main/accepted/2020/or-greater-defines/or-greater-defines.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am cheating here. The net6.0 TFM does not define NETSTANDARD because it is not, but since maui treats net6 and netstd the same, I am pretending that net6.0 is netstd.
handler.RootComponents = webView.RootComponents; | ||
handler.StartWebViewCoreIfPossible(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove these empty lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we can. :)
Description of Change
Add the .NET 6.0 (net6.0) TFM to the packages.