Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net6.0 to the projects #1810

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Add net6.0 to the projects #1810

merged 3 commits into from
Jul 26, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

Add the .NET 6.0 (net6.0) TFM to the packages.

@mattleibow mattleibow requested a review from Eilon as a code owner July 26, 2021 13:58
@@ -63,6 +63,11 @@
<MonoAndroidAssetsPrefix>$(AndroidProjectFolder)Assets</MonoAndroidAssetsPrefix>
</PropertyGroup>

<!-- .NET Standard or .NET 6 -->
<PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'">
<DefineConstants>$(DefineConstants);NETSTANDARD</DefineConstants>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am cheating here. The net6.0 TFM does not define NETSTANDARD because it is not, but since maui treats net6 and netstd the same, I am pretending that net6.0 is netstd.

handler.RootComponents = webView.RootComponents;
handler.StartWebViewCoreIfPossible();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these empty lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can. :)

@mattleibow mattleibow added this to the 6.0.100-preview.7 milestone Jul 26, 2021
@PureWeen PureWeen merged commit 889d7f4 into main Jul 26, 2021
@PureWeen PureWeen deleted the dev/net6 branch July 26, 2021 21:22
@samhouts samhouts added area-blazor Blazor Hybrid / Desktop, BlazorWebView area-controls-webview WebView labels Jul 10, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView area-controls-webview WebView fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants