Update car image/size #18550
Merged
Update car image/size #18550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-templates
mattleibow
previously approved these changes
Nov 6, 2023
rmarinho
previously approved these changes
Nov 7, 2023
The old image name was used in a bunch of tests, it's still the bot so the old name is still fine, and seems like reasonable idea to just revert the name to clean this up.
PureWeen
approved these changes
Nov 7, 2023
|
/backport to release/8.0.1xx |
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/maui/actions/runs/6787960579 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the previous change, the source png was not set to resize=true, and the BaseSize attribute in the project was not set to match the usage in xaml. This make the sizes consistent everywhere, and shrinks the source png a bit, while adding resize=true in order to make the png scale appropriately to different densities.
This should address the regression in startup performance we noticed on Android due to this change.