Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy the System.*.dll to .nuspec as this is no longer needed in .nuspec #1873

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

The System.*.dll is no longer needed when building on the Mac with the IDE since that is using .NET Core.

@mattleibow mattleibow added this to the 6.0.100-preview.7 milestone Jul 30, 2021
@Redth Redth requested a review from rmarinho August 2, 2021 14:09
@rmarinho
Copy link
Member

rmarinho commented Aug 2, 2021

How do we test this? now with the workload ?

@mattleibow
Copy link
Member Author

You can test with a git clean -xdf and then a build of the BuildTask and see if the VS Mac IDE opens.

Previously the vsmac ide required the use of full framework dlls, but now that it has support for dotnet core stuff, it won't work with the full stuff. All the bits that get copied are now used and throw.

If the IDE opens and you can build, then you are good.

This is just local IDE dev things.

@mattleibow mattleibow merged commit 6d8ea52 into release/6.0.1xx-preview7 Aug 3, 2021
@mattleibow mattleibow deleted the dev/fix-vsmac branch August 3, 2021 03:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants