Make sure that Star rows/columns get an auto-sizing measure when constraints are infinite #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkang
approved these changes
Jul 30, 2021
samhouts
added
area-layout
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given an infinite constraint along an axis with a Star value, GridLayout can't distribute the Star values normally (because they'd all be infinite).
Instead, GridLayout treats Star values in this case as Auto values, and gives the elements inside the values they request.
In some circumstances, the GridLayout was doing this without ever actually measuring the element, giving the Star value the default of zero. These changes ensure that the element is actually measured in these circumstances.