Update the versions in the templates to the real values #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
changed the title
mattleibow
commented
Aug 3, 2021
Comment on lines
+38
to
+39
| .Replace('MICROSOFT_EXTENSIONS_VERSION_VALUE', '$(MicrosoftExtensionsFileProvidersEmbeddedPackageVersion)') | ||
| .Replace('PROJECT_REUNION_VERSION_VALUE', '$(_MicrosoftProjectReunionVersion)'))" /> |
There was a problem hiding this comment.
The hackiest way, but basically replace the values in the json files with the props values.
|
The logic looks legit, but does it leave the files changed on disk? What I did in another project where I had a similar problem is that the checked-in files were called |
|
I am working in the obj directory, so we should be safe. |
…ev/replace-template-versions
rmarinho
requested changes
Aug 3, 2021
There was a problem hiding this comment.
D:\agent\1\s\bin\dotnet\sdk\6.0.100-preview.7.21379.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(137,5): error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked. [D:\agent\1\s\src\Templates\src\Microsoft.Maui.Templates.csproj]
Eilon
approved these changes
Aug 3, 2021
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use the version that we built against in the templates.