Restore LogicalChildren for Hot Reload #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
requested review from
drasticactions,
hartez and
PureWeen
and removed request for
drasticactions and
hartez
|
I believe this might not be needed since there is an insertion this week for the new HR in P3. Also, the current HR is broken due to a change in another VS component. |
mattleibow
changed the title
…ev/logical-children
…ev/logical-children
Redth
approved these changes
Aug 3, 2021
mattleibow
changed the title
samhouts
added
area-controls-collectionview
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Hot Reload uses the
LogicalChldrenproperty still in the current previews, so add it back.Because we are using
IReadOnlyList<T>, we do have to wrap it in a special conversion class. This is Only used by Hot Reload, and we can't use the value directly because Hot Reload expects a very specific type.