Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workload] add missing Microsoft.Maui.Controls.aar #2007

Conversation

jonathanpeppers
Copy link
Member

Description of Change

Fixes? https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1364884

The Microsoft.Maui.Controls.aar file is missing from the workload,
which includes the following Android resources:

res\anim\enterfromleft.xml
res\anim\enterfromright.xml
res\anim\exittoleft.xml
res\anim\exittoright.xml
res\values\strings.xml
res\layout\bottomtablayout.xml
res\layout\flyoutcontent.xml
res\layout\shellcontent.xml
res\layout\shellrootlayout.xml

I don't know what Android resources are needed and which package they
go in. We should actually do an audit and see if any are missing.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

No

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Aug 9, 2021

This seems like it was this way for the entirety of .NET MAUI Preview 6, and I guess no one noticed until now?

@mattleibow mattleibow changed the base branch from main to release/6.0.1xx-preview7 August 9, 2021 16:41
@mattleibow mattleibow requested a review from Eilon as a code owner August 9, 2021 16:41
@mattleibow mattleibow changed the base branch from release/6.0.1xx-preview7 to main August 9, 2021 16:41
Fixes? https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1364884

The `Microsoft.Maui.Controls.aar` file is missing from the workload,
which includes the following Android resources:

    res\anim\enterfromleft.xml
    res\anim\enterfromright.xml
    res\anim\exittoleft.xml
    res\anim\exittoright.xml
    res\values\strings.xml
    res\layout\bottomtablayout.xml
    res\layout\flyoutcontent.xml
    res\layout\shellcontent.xml
    res\layout\shellrootlayout.xml

I don't know what Android resources are needed and which package they
go in. We should actually do an audit and see if any are missing.
@jonathanpeppers jonathanpeppers changed the base branch from main to release/6.0.1xx-preview7 August 9, 2021 16:42
@Redth Redth added this to the 6.0.100-preview.7 milestone Aug 9, 2021
@Redth Redth merged commit d878703 into dotnet:release/6.0.1xx-preview7 Aug 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants