Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Rectangle parameter for ArrangeChildren #2014

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Aug 10, 2021

Reinstate the Rectangle parameter for ILayoutManager.ArrangeChildren; zero out bounds parameters for CrossPlatformArrange calls on Windows/Android.

Also adds implementations for non-zero origins when arranging GridLayout, FlexLayout. Adds unit tests for non-zero origins for layout managers.

@mattleibow mattleibow changed the title Restore Rectangle parameter for ArrangeChildren; zero out native layo… Restore Rectangle parameter for ArrangeChildren Aug 10, 2021
@mattleibow mattleibow merged commit eab6a1e into release/6.0.1xx-preview7 Aug 10, 2021
@mattleibow mattleibow deleted the ac-rect branch August 10, 2021 05:38
@samhouts samhouts added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter layout-flex FlexLayout issues layout-grid layout-stack platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! layout-flex FlexLayout issues layout-grid layout-stack platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants