Support the unpackaged format for font loading #20790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
approved these changes
Feb 22, 2024
rmarinho
approved these changes
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds some logic similar to what was added to loading the font family name using Win2D. It has to convert the MSIX URI format to the file:// URI format.
This does not fix fix the issue as we also need a Win2D update that actually has the other half of the fix.
I need to add tests still, but we could potentially merge this for now and add tests in the https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample.UITests/Concepts/ImageLoadingGalleryPage.cs and https://github.com/dotnet/maui/blob/main/src/Controls/tests/UITests/Tests/Concepts/ImageLoadingGalleryTests.cs files. I currently just added the tests for the file-based images, not the generated ones.
Issues Fixed
Almost fixes #15802