Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arcade] Apps need to use ApplicationDisplayVersion for the version #22472

Merged
merged 3 commits into from
May 17, 2024
Merged

[arcade] Apps need to use ApplicationDisplayVersion for the version #22472

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df70a12
Update to correct ExcludeMicrosoftNetTestSdk
rmarinho May 16, 2024
773c76f
Better control the versioning for apps
mattleibow May 16, 2024
68230e4
Merge remote-tracking branch 'origin/main' into fix-test-sdk
mattleibow May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Maui.InTree.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@

</ImportGroup>

<!--
Workaround for Arcade versioning. We need to force the Arcade properties
to match the value in the csproj property ApplicationDisplayVersion.
-->
<PropertyGroup Condition="'$(ApplicationDisplayVersion)' != ''">
<_TempApplicationDisplayVersion>$(ApplicationDisplayVersion).0.0.0</_TempApplicationDisplayVersion>
<MajorVersion>$(_TempApplicationDisplayVersion.Split('.')[0])</MajorVersion>
<MinorVersion>$(_TempApplicationDisplayVersion.Split('.')[1])</MinorVersion>
<PatchVersion>$(_TempApplicationDisplayVersion.Split('.')[2])</PatchVersion>
<PreReleaseVersionLabel></PreReleaseVersionLabel>
<!-- App versions cannot be prerelease since they are 3 or 4 part numbers in manifests. -->
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
</PropertyGroup>

<!--
This is a targets file, but needs to go here as it must come after the csproj but before the NuGet packages.
In the release .NET MAUI SDK, this is imported by the workloads which puts it in the middle as well.
Expand Down
Loading