Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Setting background color on the Searchbar - fix #23355

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jun 28, 2024

Issues Fixed

Fixes #23325
Fixes #24100

@kubaflo kubaflo requested a review from a team as a code owner June 28, 2024 22:42
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 28, 2024
@Redth
Copy link
Member

Redth commented Jul 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jul 18, 2024
@PureWeen
Copy link
Member

PureWeen commented Aug 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@samhouts samhouts added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Aug 29, 2024
@aheubusch
Copy link
Contributor

@kubaflo @PureWeen I think I see another bug. Once a custom BackgroundColor has been set its not possible to return to the default color (searchHandler.BackgroundColor = null;). Infact it will cause a NRE in line 168 (backGroundColor.ToPlatform()).
Proposed change to line 154

if (backGroundColor == null)
{
	_hasCustomBackground = false;
	
	backgroundView.Layer.CornerRadius = 0;
	backgroundView.ClipsToBounds = false;
	backgroundView.BackgroundColor = _defaultBackgroundColor;
	textField.BackgroundColor = _defaultBackgroundColor;
	
	return;
}

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
10 participants